feat: Adds SkipDefaultAlertsSettings and GenAIFeaturesEnabled to Organization, maximumThroughput to Trigger and deprecates ServerlessInstance, ServerlessPrivateEndpoint and Serverless type in CloudBackupRestoreJobs and
#415
Conversation
| * @default true` for new Atlas Organizations created with the provider to prevent infrastructure drift caused by creation of new alerts. | ||
| * @schema CfnOrganizationProps#SkipDefaultAlertsSettings | ||
| */ | ||
| readonly skipDefaultAlertsSettings?: boolean; |
There was a problem hiding this comment.
Would confirm with @maastha, not sure if this change has been released yet
There was a problem hiding this comment.
This is being picked up in the CI (see failure), that's why I included it. If it can't be included in this I will work around this
There was a problem hiding this comment.
talked with @maastha, I'll wait to merge and release a CDK version with these changes until next week.
There was a problem hiding this comment.
@oarbusi in any case I think it's best practice you separate this. First you do a PR with these changes if they are blocking and then you do a PR for deprecation.
When I open the PR and see the title I don't expect these changes to be here.
There was a problem hiding this comment.
@marcosuma Because both changes are now in CFN repo master branch, and how this repo works, CI checks detect both changes, and separate PRs would have failing CI checks, which is not ideal IMO. That is why I prefer to not split it if possible and to just wait. I can change this PR title to accomodate both changes
oarbusi
changed the title
SkipDefaultAlertsSettings and GenAIFeaturesEnabled to Organization and deprecates ServerlessInstance, ServerlessPrivateEndpoint and Serverless type in CloudBackupRestoreJobs and
oarbusi
changed the title
SkipDefaultAlertsSettings and GenAIFeaturesEnabled to Organization and deprecates ServerlessInstance, ServerlessPrivateEndpoint and Serverless type in CloudBackupRestoreJobs and SkipDefaultAlertsSettings and GenAIFeaturesEnabled to Organization, maximumThroughput to Trigger and deprecates ServerlessInstance, ServerlessPrivateEndpoint and Serverless type in CloudBackupRestoreJobs and
Proposed changes
Deprecates ServerlessInstance, ServerlessPrivateEndpoint and Serverless type in CloudBackupRestoreJobs
Followup of Cloudformation deprecation mongodb/mongodbatlas-cloudformation-resources#1306
Link to any related issue(s): CLOUDP-277813
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments