-
Notifications
You must be signed in to change notification settings - Fork 21
fix: Fixes NuGet Release failure #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| run: cd .repo && yarn install --check-files --frozen-lockfile | ||
| - name: Create dotnet artifact | ||
| run: cd .repo && npx projen compile && npx projen package:dotnet | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this job depends on release job, ideally we would get all the info from the dist artifact (in previous step).
Did you try to do that?
If you run npx projen release -i you can see that build, compile, package:dotnet are all part of the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other packaging run cd .repo && npx projen compile && npx projen package:python/go/etc so I think the easier and most consistent solution is to just add the npx projen bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| with: | ||
| path: .repo | ||
| fetch-depth: 0 | ||
| - name: Install Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know why it has started to fail now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only relevant changes that have happened to the repo since last release are mostly dependency updates. I think some dependency got updated here (maybe jsii from 1.X to 5.6 😅), but I am not 100% sure
EspenAlbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you

Proposed changes
Fixes the release of NuGet (issue)
The error was
when trying to sign the nuget package.
After investigataion, I realized that the NuGet package was being generated but with the wrong name,
MongoDB.AWSCDKResourcesMongoDBAtlas.0.0.0.nupkg(not the expected version number).To fix this the
npx projen bumpcommand is needed to bump the version in thepackage.jsonfile. The projen bump command needs to:To do this, it needs access to:
That is why I added
fetch-depth: 0so that the full git history is fetched, instead of just doing a shallow copy (default fetch-depth: 1`)Tested this change running a modified version of the Action defined here: #422
And with those changes the resulting dotnet package is
MongoDB.AWSCDKResourcesMongoDBAtlas.3.10.0.nupkgLink to any related issue(s): CLOUDP-309125
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments