Skip to content

fix: Fixes NuGet Release failure #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

fix: Fixes NuGet Release failure #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,15 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
with:
path: .repo
fetch-depth: 0
- name: Install Dependencies
Copy link
Member

@lantoli lantoli Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why it has started to fail now?

Copy link
Collaborator Author

@oarbusi oarbusi Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only relevant changes that have happened to the repo since last release are mostly dependency updates. I think some dependency got updated here (maybe jsii from 1.X to 5.6 😅), but I am not 100% sure

run: cd .repo && yarn install --check-files --frozen-lockfile
- name: Create dotnet artifact
run: cd .repo && npx projen compile && npx projen package:dotnet
run: |
Copy link
Collaborator

@EspenAlbert EspenAlbert Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this job depends on release job, ideally we would get all the info from the dist artifact (in previous step).
Did you try to do that?
If you run npx projen release -i you can see that build, compile, package:dotnet are all part of the release.

Copy link
Collaborator Author

@oarbusi oarbusi Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other packaging run cd .repo && npx projen compile && npx projen package:python/go/etc so I think the easier and most consistent solution is to just add the npx projen bump.

Copy link
Collaborator

@EspenAlbert EspenAlbert Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the dist artifact and it looks like the dotnet is not built and uploaded (guess it would require installing dependencies in the first job)
Could be an improvement for later, but understand it is out-of-scope for this PR
image

cd .repo
npx projen bump
npx projen compile
npx projen package:dotnet
- name: Collect dotnet Artifact
run: mv .repo/dist/dotnet dist/dotnet
- name: Extract Version
Expand Down
Loading