RUST-427 Drop decode_document_utf8_lossy (#172)

Author: isabelatkinson

src/decoder/mod.rs

@@ -130,28 +130,6 @@ pub fn decode_document<R: Read + ?Sized>(reader: &mut R) -> DecoderResult<Docume
     Ok(doc)
 }
 
-/// Attempt to decode a `Document` that may contain invalid UTF-8 strings from a byte stream.
-pub fn decode_document_utf8_lossy<R: Read + ?Sized>(reader: &mut R) -> DecoderResult<Document> {
-    let mut doc = Document::new();
-
-    // disregard the length: using Read::take causes infinite type recursion
-    read_i32(reader)?;
-
-    loop {
-        let tag = reader.read_u8()?;
-
-        if tag == 0 {
-            break;
-        }
-
-        let (key, val) = decode_bson_kvp(reader, tag, true)?;
-
-        doc.insert(key, val);
-    }
-
-    Ok(doc)
-}
-
 fn decode_array<R: Read + ?Sized>(reader: &mut R, utf8_lossy: bool) -> DecoderResult<Array> {
     let mut arr = Array::new();
 

src/lib.rs

@@ -53,14 +53,7 @@ pub use self::{
         TimeStamp,
         UtcDateTime,
     },
-    decoder::{
-        decode_document,
-        decode_document_utf8_lossy,
-        from_bson,
-        Decoder,
-        DecoderError,
-        DecoderResult,
-    },
+    decoder::{decode_document, from_bson, Decoder, DecoderError, DecoderResult},
     document::{ValueAccessError, ValueAccessResult},
     encoder::{encode_document, to_bson, Encoder, EncoderError, EncoderResult},
 };

tests/modules/encoder_decoder.rs

@@ -2,7 +2,6 @@
 use bson::decimal128::Decimal128;
 use bson::{
     decode_document,
-    decode_document_utf8_lossy,
     doc,
     encode_document,
     oid::ObjectId,
@@ -54,21 +53,6 @@ fn test_encode_decode_utf8_string() {
     assert_eq!(decoded, doc);
 }
 
-#[test]
-fn test_encode_decode_utf8_string_invalid() {
-    let bytes = b"\x80\xae".to_vec();
-    let src = unsafe { String::from_utf8_unchecked(bytes) };
-
-    let doc = doc! { "key": src };
-
-    let mut buf = Vec::new();
-    encode_document(&mut buf, &doc).unwrap();
-
-    let expected = doc! { "key": "��" };
-    let decoded = decode_document_utf8_lossy(&mut Cursor::new(buf)).unwrap();
-    assert_eq!(decoded, expected);
-}
-
 #[test]
 fn test_encode_decode_array() {
     let src = vec![Bson::FloatingPoint(1.01), Bson::String("xyz".to_owned())];