Merge pull request #19 from thijsc/remove_to_owned

Remove some unnecessary to_owned calls

Author: zonyitoo

src/ordered.rs

@@ -102,7 +102,7 @@ impl<'a> Iterator for OrderedDocumentIntoIterator {
         match self.vec_iter.next() {
             Some(key) => {
                 let val = self.document.remove(&key[..]).unwrap();
-                Some((key, val.to_owned()))
+                Some((key, val))
             },
             None => None,
         }
@@ -202,7 +202,7 @@ impl OrderedDocument {
         }
 
         self.keys.push(key.to_owned());
-        self.document.insert(key, val.to_owned())
+        self.document.insert(key, val)
     }
 
     /// Takes the value of the entry out of the document, and returns it.

tests/modules/bson.rs

@@ -3,9 +3,9 @@ use bson::{Bson, Document};
 #[test]
 fn to_json() {
     let mut doc = Document::new();
-    doc.insert("first".to_owned(), Bson::I32(1));
-    doc.insert("second".to_owned(), Bson::String("foo".to_owned()));
-    doc.insert("alphanumeric".to_owned(), Bson::String("bar".to_owned()));
+    doc.insert("first", Bson::I32(1));
+    doc.insert("second", Bson::String("foo".to_owned()));
+    doc.insert("alphanumeric", Bson::String("bar".to_owned()));
     let data = Bson::Document(doc).to_json();
 
     assert!(data.is_object());

tests/modules/encoder.rs

@@ -25,7 +25,7 @@ fn test_encode_utf8_string() {
     let dst = [28, 0, 0, 0, 2, 107, 101, 121, 0, 14, 0, 0, 0, 116, 101, 115, 116, 228, 189, 160, 229, 165, 189, 229, 144, 151, 0, 0];
 
     let mut doc = Document::new();
-    doc.insert("key".to_owned(), Bson::String(src));
+    doc.insert("key", Bson::String(src));
 
     let mut buf = Vec::new();
     encode_document(&mut buf, &doc).unwrap();
@@ -39,7 +39,7 @@ fn test_encode_array() {
     let dst = [37, 0, 0, 0, 4, 107, 101, 121, 0, 27, 0, 0, 0, 1, 48, 0, 41, 92, 143, 194, 245, 40, 240, 63, 2, 49, 0, 4, 0, 0, 0, 120, 121, 122, 0, 0, 0];
 
     let mut doc = Document::new();
-    doc.insert("key".to_owned(), Bson::Array(src));
+    doc.insert("key", Bson::Array(src));
 
     let mut buf = Vec::new();
     encode_document(&mut buf, &doc).unwrap();
@@ -53,7 +53,7 @@ fn test_encode_utc_date_time() {
     let dst = [18, 0, 0, 0, 9, 107, 101, 121, 0, 208, 111, 158, 149, 43, 1, 0, 0, 0];
 
     let mut doc = Document::new();
-    doc.insert("key".to_owned(), Bson::UtcDatetime(src));
+    doc.insert("key", Bson::UtcDatetime(src));
 
     let mut buf = Vec::new();
     encode_document(&mut buf, &doc).unwrap();

tests/modules/ordered.rs

@@ -37,9 +37,9 @@ fn ordered_insert_shorthand() {
 #[test]
 fn remove() {
     let mut doc = Document::new();
-    doc.insert("first".to_owned(), Bson::I32(1));
-    doc.insert("second".to_owned(), Bson::String("foo".to_owned()));
-    doc.insert("alphanumeric".to_owned(), Bson::String("bar".to_owned()));
+    doc.insert("first", Bson::I32(1));
+    doc.insert("second", Bson::String("foo".to_owned()));
+    doc.insert("alphanumeric", Bson::String("bar".to_owned()));
 
     assert!(doc.remove("second").is_some());
     assert!(doc.remove("none").is_none());