changed binary values to print out as numbers

Author: saghm

src/bson.rs

@@ -75,7 +75,7 @@ impl Display for Bson {
 
                 string.push_str("]");
                 string
-            },
+            }
             &Bson::Document(ref doc) => format!("{}", doc),
             &Bson::Boolean(b) => format!("{}", b),
             &Bson::Null => "null".to_owned(),
@@ -89,11 +89,8 @@ impl Display for Bson {
                 let inc = (i & 0xFFFFFFFF) as i32;
 
                 format!("Timestamp({}, {})", time, inc)
-            },
-            &Bson::Binary(t, ref vec) => {
-                let string = unsafe { str::from_utf8_unchecked(vec) };
-                format!("BinData({}, \"{}\")", u8::from(t), string)
             }
+            &Bson::Binary(t, ref vec) => format!("BinData({}, {})", u8::from(t), vec.to_hex()),
             &Bson::ObjectId(ref id) => {
                 let mut vec = vec![];
 

tests/lib.rs

@@ -9,6 +9,7 @@ use bson::Bson;
 use bson::spec::BinarySubtype;
 use bson::oid::ObjectId;
 use chrono::offset::utc::UTC;
+use rustc_serialize::hex::ToHex;
 
 #[test]
 fn test_format() {
@@ -44,7 +45,7 @@ fn test_format() {
         "date" => (Bson::UtcDatetime(date))
     };
 
-    let expected = format!("{{ float: 2.4, string: \"hello\", array: [\"testing\", 1], doc: {{ fish: \"in\", a: \"barrel\", !: 1 }}, bool: true, null: null, regexp: /s[ao]d/i, code: function(x) {{ return x._id; }}, i32: 12, i64: -55, timestamp: Timestamp(0, 229999444), binary: BinData(5, \"thingies\"), _id: ObjectId(\"{}\"), date: Date(\"{}\") }}", id_string, date);
+    let expected = format!("{{ float: 2.4, string: \"hello\", array: [\"testing\", 1], doc: {{ fish: \"in\", a: \"barrel\", !: 1 }}, bool: true, null: null, regexp: /s[ao]d/i, code: function(x) {{ return x._id; }}, i32: 12, i64: -55, timestamp: Timestamp(0, 229999444), binary: BinData(5, {}), _id: ObjectId(\"{}\"), date: Date(\"{}\") }}", "thingies".as_bytes().to_hex(), id_string, date);
 
     assert_eq!(expected, format!("{}", doc));
 }