minor: fix clippy

Author: patrickfreed

examples/serialize.rs

@@ -1,17 +1,18 @@
 use std::io::Cursor;
 
-use bson::{oid, Array, Bson, Document};
+use bson::{oid, Bson, Document};
 
 fn main() {
     let mut doc = Document::new();
     doc.insert("foo".to_string(), Bson::String("bar".to_string()));
 
-    let mut arr = Array::new();
-    arr.push(Bson::String("blah".to_string()));
-    arr.push(Bson::DateTime(chrono::Utc::now()));
-    arr.push(Bson::ObjectId(oid::ObjectId::with_bytes([
-        1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12,
-    ])));
+    let arr = vec![
+        Bson::String("blah".to_string()),
+        Bson::DateTime(chrono::Utc::now()),
+        Bson::ObjectId(oid::ObjectId::with_bytes([
+            1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12,
+        ])),
+    ];
 
     doc.insert("array".to_string(), Bson::Array(arr));
 

serde-tests/test.rs

@@ -1,4 +1,5 @@
 #![allow(clippy::cognitive_complexity)]
+#![allow(clippy::vec_init_then_push)]
 
 use serde::{self, de::Unexpected, Deserialize, Serialize};
 use std::collections::{BTreeMap, HashSet};

src/decimal128.rs

@@ -239,9 +239,9 @@ impl std::str::FromStr for Decimal128 {
 }
 
 #[cfg(feature = "decimal128")]
-impl Into<d128> for Decimal128 {
-    fn into(self) -> d128 {
-        self.inner
+impl From<Decimal128> for d128 {
+    fn from(decimal: Decimal128) -> d128 {
+        decimal.inner
     }
 }
 

src/extjson/de.rs

@@ -146,12 +146,12 @@ impl TryFrom<serde_json::Map<String, serde_json::Value>> for Bson {
 
         if obj.contains_key("$minKey") {
             let min_key: models::MinKey = serde_json::from_value(obj.into())?;
-            return Ok(min_key.parse()?);
+            return min_key.parse();
         }
 
         if obj.contains_key("$maxKey") {
             let max_key: models::MaxKey = serde_json::from_value(obj.into())?;
-            return Ok(max_key.parse()?);
+            return max_key.parse();
         }
 
         if obj.contains_key("$dbPointer") {
@@ -174,7 +174,7 @@ impl TryFrom<serde_json::Map<String, serde_json::Value>> for Bson {
 
         if obj.contains_key("$undefined") {
             let undefined: models::Undefined = serde_json::from_value(obj.into())?;
-            return Ok(undefined.parse()?);
+            return undefined.parse();
         }
 
         Ok(Bson::Document(obj.try_into()?))