fix collisions with projected columns and order by columns

Author: WaVEV

django_mongodb/compiler.py

@@ -357,9 +357,7 @@ def build_query(self, columns=None):
         if columns is None:
             extra_fields += ordering_fields
         if extra_fields:
-            query.extra_fields = {
-                field_name: expr.as_mql(self, self.connection) for field_name, expr in extra_fields
-            }
+            query.extra_fields = self.get_project_fields(extra_fields, force_expression=True)
         where = self.get_where()
         try:
             expr = where.as_mql(self, self.connection) if where else {}
@@ -429,16 +427,18 @@ def _get_aggregate_expressions(self, expr):
             elif hasattr(expr, "get_source_expressions"):
                 stack.extend(expr.get_source_expressions())
 
-    def get_project_fields(self, columns=None, ordering=None):
+    def get_project_fields(self, columns=None, ordering=None, force_expression=False):
+        if not columns:
+            return {}
         fields = defaultdict(dict)
-        for name, expr in columns or []:
+        for name, expr in columns + (ordering or ()):
             collection = expr.alias if isinstance(expr, Col) else None
             try:
                 fields[collection][name] = (
                     1
                     # For brevity/simplicity, project {"field_name": 1}
                     # instead of {"field_name": "$field_name"}.
-                    if isinstance(expr, Col) and name == expr.target.column
+                    if isinstance(expr, Col) and name == expr.target.column and not force_expression
                     else expr.as_mql(self, self.connection)
                 )
             except EmptyResultSet:
@@ -449,9 +449,6 @@ def get_project_fields(self, columns=None, ordering=None):
         # should appear in the top-level of the fields dict.
         fields.update(fields.pop(None, {}))
         fields.update(fields.pop(self.collection_name, {}))
-        # Add order_by() fields.
-        if fields and ordering:
-            fields.update({alias: expr.as_mql(self, self.connection) for alias, expr in ordering})
         # Convert defaultdict to dict so it doesn't appear as
         # "defaultdict(<CLASS 'dict'>, ..." in query logging.
         return dict(fields)
@@ -471,7 +468,7 @@ def _get_ordering(self):
         for order in self.order_by_objs or []:
             if isinstance(order.expression, Col):
                 field_name = order.expression.as_mql(self, self.connection).removeprefix("$")
-                fields[field_name] = order.expression
+                fields[order.expression.target.column] = order.expression
             elif isinstance(order.expression, Ref):
                 field_name = order.expression.as_mql(self, self.connection).removeprefix("$")
             else:

django_mongodb/features.py

@@ -63,8 +63,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
         "aggregation.tests.AggregateTestCase.test_reverse_fkey_annotate",
         "aggregation_regress.tests.AggregationTests.test_annotation_disjunction",
         "aggregation_regress.tests.AggregationTests.test_decimal_aggregate_annotation_filter",
-        # Invalid $project :: caused by :: Path collision at aggregation_regress_publisher.name
-        "aggregation_regress.tests.AggregationTests.test_values_list_annotation_args_ordering",
         # QuerySet.extra(select=...) should raise NotSupportedError instead of:
         # 'RawSQL' object has no attribute 'as_mql'.
         "aggregation_regress.tests.AggregationTests.test_annotate_with_extra",