Skip to content

Commit 3771a36

Browse files
committed
Refactor fixed_size and size in array field
1 parent a26977d commit 3771a36

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

django_mongodb_backend/fields/array.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,22 @@ class ArrayField(CheckFieldDefaultMixin, Field):
2828
}
2929
_default_hint = ("list", "[]")
3030

31-
def __init__(self, base_field, size=None, fixed_size=None, **kwargs):
31+
def __init__(self, base_field, max_size=None, size=None, **kwargs):
3232
self.base_field = base_field
33-
self.size = size
34-
self.fixed_size = fixed_size
35-
if fixed_size and size:
33+
self.size = max_size
34+
self.fixed_size = size
35+
if size and max_size:
3636
raise ValueError("Cannot define both, size and fixed_size")
3737

38-
if self.size:
38+
if self.max_size:
3939
self.default_validators = [
4040
*self.default_validators,
41-
ArrayMaxLengthValidator(self.size),
41+
ArrayMaxLengthValidator(self.max_size),
4242
]
43-
if self.fixed_size:
43+
if self.size:
4444
self.default_validators = [
4545
*self.default_validators,
46-
LengthValidator(self.fixed_size),
46+
LengthValidator(self.size),
4747
]
4848
# For performance, only add a from_db_value() method if the base field
4949
# implements it.

django_mongodb_backend/indexes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,9 @@ def create_mongodb_index(
250250
mappings = {"path": field_path}
251251
if isinstance(field_, ArrayField):
252252
try:
253-
vector_size = int(field_.fixed_size)
253+
vector_size = int(field_.size)
254254
except (ValueError, TypeError) as err:
255-
raise ValueError("Atlas vector search requires fixed size.") from err
255+
raise ValueError("Atlas vector search requires size.") from err
256256
if not isinstance(field_.base_field, FloatField | DecimalField):
257257
raise ValueError("Base type must be Float or Decimal.")
258258
mappings.update(

0 commit comments

Comments
 (0)