Skip to content

Commit 5cbdde5

Browse files
committed
remove redundant check.
1 parent e566eb5 commit 5cbdde5

File tree

1 file changed

+17
-20
lines changed

1 file changed

+17
-20
lines changed

django_mongodb/compiler.py

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -475,26 +475,23 @@ def get_combinator_queries(self):
475475
if not parts:
476476
raise EmptyResultSet
477477
combinator_pipeline = parts.pop(0)[0].get_pipeline()
478-
if self.query.combinator == "union":
479-
for part, collection in parts:
480-
combinator_pipeline.append(
481-
{"$unionWith": {"coll": collection, "pipeline": part.get_pipeline()}}
482-
)
483-
if not self.query.combinator_all:
484-
ids = {}
485-
for alias, expr in main_query_columns:
486-
# Unfold foreign fields.
487-
if isinstance(expr, Col) and expr.alias != self.collection_name:
488-
ids[self._unfold_column(expr)] = expr.as_mql(self, self.connection)
489-
else:
490-
ids[alias] = f"${alias}"
491-
combinator_pipeline.append({"$group": {"_id": ids}})
492-
projected_fields = self._fold_columns(ids)
493-
combinator_pipeline.append({"$addFields": projected_fields})
494-
if "_id" not in projected_fields:
495-
combinator_pipeline.append({"$unset": "_id"})
496-
else:
497-
raise NotSupportedError(f"Combinator {self.query.combinator} isn't supported.")
478+
for part, collection in parts:
479+
combinator_pipeline.append(
480+
{"$unionWith": {"coll": collection, "pipeline": part.get_pipeline()}}
481+
)
482+
if not self.query.combinator_all:
483+
ids = {}
484+
for alias, expr in main_query_columns:
485+
# Unfold foreign fields.
486+
if isinstance(expr, Col) and expr.alias != self.collection_name:
487+
ids[self._unfold_column(expr)] = expr.as_mql(self, self.connection)
488+
else:
489+
ids[alias] = f"${alias}"
490+
combinator_pipeline.append({"$group": {"_id": ids}})
491+
projected_fields = self._fold_columns(ids)
492+
combinator_pipeline.append({"$addFields": projected_fields})
493+
if "_id" not in projected_fields:
494+
combinator_pipeline.append({"$unset": "_id"})
498495
return combinator_pipeline
499496

500497
def get_lookup_pipeline(self):

0 commit comments

Comments
 (0)