Skip to content

Commit 6afce5a

Browse files
committed
Code review fixes (6/x)
1 parent 917e3a8 commit 6afce5a

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

.github/workflows/test-python-atlas.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
- name: install django-mongodb-backend
2929
run: |
3030
pip3 install --upgrade pip
31-
pip3 install ".[encryption]"
3231
pip3 install -e .
3332
- name: Checkout Django
3433
uses: actions/checkout@v4

.github/workflows/test-python.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
- name: install django-mongodb-backend
2929
run: |
3030
pip3 install --upgrade pip
31-
pip3 install ".[encryption]"
3231
pip3 install -e .
3332
- name: Checkout Django
3433
uses: actions/checkout@v4

docs/source/howto/queryable-encryption.rst

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ steps required for Django.
2020
Prerequisites
2121
-------------
2222

23-
.. TODO Add something about crypt_shared here.
24-
2523
In addition to :doc:`installing </intro/install>` and :doc:`configuring
2624
</intro/configure>` Django MongoDB Backend, you will need to install some
2725
additional packages to use Queryable Encryption. This can be done with the
@@ -135,6 +133,15 @@ settings::
135133
If you get the error ``Unknown command: 'createcachecollection'``, ensure
136134
``"django_mongodb_backend"`` is in your :setting:`INSTALLED_APPS` setting.
137135

136+
Crypt shared library
137+
~~~~~~~~~~~~~~~~~~~~
138+
139+
Additionally, you will need to ensure that the :ref:`crypt shared library is
140+
available <manual:qe-reference-shared-library>` to your Python environment.
141+
The crypt shared library is recommended over libmongocrypt for Queryable
142+
Encryption because it doesn't require an additional daemon process to run to
143+
facilitate Queryable Encryption operations.
144+
138145
Settings
139146
~~~~~~~~
140147

tests/encryption_/test_schema.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,15 @@ class QueryableEncryptionSchemaTests(QueryableEncryptionTestCase):
1111
available_apps = ["encryption_"]
1212

1313
def test_get_encrypted_fields_map(self):
14-
"""Test class method called by schema editor
15-
and management command to get encrypted fields map for
16-
`create_encrypted_collection` and `auto_encryption_opts` respectively.
17-
There are no data keys in the results.
14+
"""
15+
Test class method called by schema editor and management command to get
16+
encrypted fields map for `create_collection` and `auto_encryption_opts`
17+
respectively. There are no data keys in the results.
1818
1919
Data keys for the schema editor are created by
20-
`create_encrypted_collection` and data keys for the
21-
management command are created by the management command
22-
using code similar to the code in `create_encrypted_collection`
23-
in Pymongo.
20+
`create_encrypted_collection` and data keys for the management command
21+
are created by the management command using code similar to the code in
22+
create_encrypted_collection` in Pymongo.
2423
"""
2524
expected_encrypted_fields_map = {
2625
"fields": [

0 commit comments

Comments
 (0)