add EmbeddedModelField support to ArrayField

Author: timgraham

django_mongodb_backend/fields/embedded_model_array.py

@@ -3,6 +3,7 @@
 from .. import forms
 from . import EmbeddedModelField
 from .array import ArrayField
+from .embedded_model import EMFExact
 
 
 class EmbeddedModelArrayField(ArrayField):
@@ -44,3 +45,19 @@ def formfield(self, **kwargs):
                 **kwargs,
             },
         )
+
+    def get_transform(self, name):
+        # TODO: ...
+        return self.base_field.get_transform(name)
+        # Copied from EmbedddedModelField -- customize?
+        #        transform = super().get_transform(name)
+        #        if transform:
+        #            return transform
+        #        field = self.embedded_model._meta.get_field(name)
+        #        return KeyTransformFactory(name, field)
+
+
+@EmbeddedModelArrayField.register_lookup
+class EMFArrayExact(EMFExact):
+    # TODO
+    pass

tests/model_fields_/test_embedded_model.py

@@ -17,14 +17,22 @@
 from django_mongodb_backend.fields import EmbeddedModelField
 from django_mongodb_backend.models import EmbeddedModel
 
+
 from .models import (
+    A,
     Address,
     Author,
+    B,
     Book,
+    C,
+    D,
     Data,
+    E,
     Holder,
     Library,
+    Movie,
     NestedData,
+    Review,
 )
 from .utils import truncate_ms
 
@@ -96,6 +104,63 @@ def test_pre_save(self):
         self.assertGreater(obj.data.auto_now, auto_now_two)
 
 
+class EmbeddedArrayTests(TestCase):
+    def test_save_load(self):
+        reviews = [
+            Review(title="The best", rating=10),
+            Review(title="Mediocre", rating=5),
+            Review(title="Horrible", rating=1),
+        ]
+        Movie.objects.create(title="Lion King", reviews=reviews)
+        movie = Movie.objects.get(title="Lion King")
+        self.assertEqual(movie.reviews[0].title, "The best")
+        self.assertEqual(movie.reviews[0].rating, 10)
+        self.assertEqual(movie.reviews[1].title, "Mediocre")
+        self.assertEqual(movie.reviews[1].rating, 5)
+        self.assertEqual(movie.reviews[2].title, "Horrible")
+        self.assertEqual(movie.reviews[2].rating, 1)
+        self.assertEqual(len(movie.reviews), 3)
+
+    def test_save_load_null(self):
+        movie = Movie.objects.create(title="Lion King")
+        movie = Movie.objects.get(title="Lion King")
+        self.assertIsNone(movie.reviews)
+
+
+class EmbeddedArrayQueryingTests(TestCase):
+    @classmethod
+    def setUpTestData(cls):
+        reviews = [
+            Review(title="The best", rating=10),
+            Review(title="Mediocre", rating=5),
+            Review(title="Horrible", rating=1),
+        ]
+        cls.clouds = Movie.objects.create(title="Clouds", reviews=reviews)
+        reviews = [
+            Review(title="Super", rating=9),
+            Review(title="Meh", rating=5),
+            Review(title="Horrible", rating=2),
+        ]
+        cls.frozen = Movie.objects.create(title="Frozen", reviews=reviews)
+        reviews = [
+            Review(title="Excellent", rating=9),
+            Review(title="Wow", rating=8),
+            Review(title="Classic", rating=7),
+        ]
+        cls.bears = Movie.objects.create(title="Bears", reviews=reviews)
+
+    def test_filter_with_field(self):
+        self.assertCountEqual(
+            Movie.objects.filter(reviews__title="Horrible"), [self.clouds, self.frozen]
+        )
+
+    def test_filter_with_model(self):
+        self.assertCountEqual(
+            Movie.objects.filter(reviews=Review(title="Horrible", rating=2)),
+            [self.clouds, self.frozen],
+        )
+
+
 class QueryingTests(TestCase):
     @classmethod
     def setUpTestData(cls):

tests/model_forms_/models.py

@@ -40,7 +40,7 @@ def __str__(self):
 class Movie(models.Model):
     title = models.CharField(max_length=255)
     reviews = EmbeddedModelArrayField(Review)
-    featured_reviews = EmbeddedModelArrayField(Review, null=True, blank=True, max_size=2)
+    featured_reviews = EmbeddedModelArrayField(Review, null=True, blank=True)
 
     def __str__(self):
         return self.title