Skip to content

Commit abb15a8

Browse files
committed
implement SchemaEditor.alter_index_together()
1 parent d2aef56 commit abb15a8

File tree

2 files changed

+32
-4
lines changed

2 files changed

+32
-4
lines changed

django_mongodb/features.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
9191
# AlterField (unique)
9292
"schema.tests.SchemaTests.test_unique",
9393
"schema.tests.SchemaTests.test_unique_and_reverse_m2m",
94-
# alter_index_together
95-
"migrations.test_operations.OperationTests.test_alter_index_together",
96-
"schema.tests.SchemaTests.test_index_together",
9794
# alter_unique_together
9895
"migrations.test_operations.OperationTests.test_alter_unique_together",
9996
"schema.tests.SchemaTests.test_unique_together",

django_mongodb/schema.py

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,14 @@ def remove_field(self, model, field):
8888
self._remove_field_index(model, field)
8989

9090
def alter_index_together(self, model, old_index_together, new_index_together):
91-
pass
91+
olds = {tuple(fields) for fields in old_index_together}
92+
news = {tuple(fields) for fields in new_index_together}
93+
# Deleted indexes
94+
for field_names in olds.difference(news):
95+
self._remove_composed_index(model, field_names, {"index": True, "unique": False})
96+
# Created indexes
97+
for field_names in news.difference(olds):
98+
self._add_composed_index(model, field_names)
9299

93100
def alter_unique_together(self, model, old_unique_together, new_unique_together):
94101
pass
@@ -127,6 +134,30 @@ def remove_index(self, model, index):
127134
return
128135
self.connection.database[model._meta.db_table].drop_index(index.name)
129136

137+
def _remove_composed_index(self, model, field_names, constraint_kwargs):
138+
"""
139+
Remove the index on the given list of field_names created by
140+
index/unique_together, depending on the constraint_kwargs.
141+
"""
142+
meta_constraint_names = {constraint.name for constraint in model._meta.constraints}
143+
meta_index_names = {constraint.name for constraint in model._meta.indexes}
144+
columns = [model._meta.get_field(field).column for field in field_names]
145+
constraint_names = self._constraint_names(
146+
model,
147+
columns,
148+
exclude=meta_constraint_names | meta_index_names,
149+
**constraint_kwargs,
150+
)
151+
if len(constraint_names) != 1:
152+
num_found = len(constraint_names)
153+
columns_str = ", ".join(columns)
154+
raise ValueError(
155+
f"Found wrong number ({num_found}) of constraints for "
156+
f"{model._meta.db_table}({columns_str})."
157+
)
158+
collection = self.connection.database[model._meta.db_table]
159+
collection.drop_index(constraint_names[0])
160+
130161
def add_constraint(self, model, constraint):
131162
pass
132163

0 commit comments

Comments
 (0)