removed mutation of getfield even when values aren't converted

Author: Jibola

django_mongodb_backend/query_conversion/expression_converters.py

@@ -79,10 +79,6 @@ def convert(cls, args):
                 if cls.operator == "$eq":
                     return {field_name: value}
                 return {field_name: {cls.operator: value}}
-            # If simple getFields are found, still mutate the original args list
-            for i, arg in enumerate(args):
-                if cls.is_simple_get_field(arg):
-                    args[i] = "$" + cls.convert_field_name(arg)
         return None
 
 
@@ -140,15 +136,6 @@ def convert(cls, in_args):
                 and all(cls.is_simple_value(v) for v in values)
             ):
                 return {field_name: {"$in": values}}
-            # Mutate the original list
-            for i, arg in enumerate(in_args):
-                if cls.is_simple_get_field(arg):
-                    in_args[i] = "$" + cls.convert_field_name(arg)
-                if isinstance(arg, list | tuple | set):
-                    arg[i] = [
-                        "$" + cls.convert_field_name(v) if cls.is_simple_get_field(v) else v
-                        for v in arg
-                    ]
         return None
 
 

tests/expression_converter_/test_match_conversion.py

@@ -223,7 +223,18 @@ def test_getfield_usage_on_dual_binary_operator(self):
                 ]
             }
         }
-        expected = [{"$match": {"$expr": {"$gt": ["$price.value", "$discounted_price.value"]}}}]
+        expected = [
+            {
+                "$match": {
+                    "$expr": {
+                        "$gt": [
+                            {"$getField": {"input": "$price", "field": "value"}},
+                            {"$getField": {"input": "$discounted_price", "field": "value"}},
+                        ]
+                    }
+                }
+            }
+        ]
         self.assertOptimizerEqual(expr, expected)
 
     def test_getfield_usage_on_onesided_binary_operator(self):