Skip to content

Commit e522e32

Browse files
committed
rename test models
1 parent 1b04e9c commit e522e32

File tree

2 files changed

+39
-55
lines changed

2 files changed

+39
-55
lines changed

tests/model_fields_/models.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,12 @@ class ArrayEnumModel(models.Model):
9494

9595

9696
# EmbeddedModelField
97-
class EmbeddedModelFieldModel(models.Model):
98-
simple = EmbeddedModelField("EmbeddedModel", null=True, blank=True)
97+
class Holder(models.Model):
98+
data = EmbeddedModelField("Data", null=True, blank=True)
9999

100100

101-
class EmbeddedModel(models.Model):
102-
someint = models.IntegerField(db_column="custom_column")
101+
class Data(models.Model):
102+
integer = models.IntegerField(db_column="custom_column")
103103
auto_now = models.DateTimeField(auto_now=True)
104104
auto_now_add = models.DateTimeField(auto_now_add=True)
105105

tests/model_fields_/test_embedded_model.py

Lines changed: 35 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -9,31 +9,28 @@
99
Address,
1010
Author,
1111
Book,
12-
EmbeddedModel,
13-
EmbeddedModelFieldModel,
12+
Data,
13+
Holder,
1414
)
1515

1616

1717
class MethodTests(SimpleTestCase):
1818
def test_deconstruct(self):
19-
field = EmbeddedModelField("EmbeddedModel", null=True)
19+
field = EmbeddedModelField("Data", null=True)
2020
name, path, args, kwargs = field.deconstruct()
2121
self.assertEqual(path, "django_mongodb_backend.fields.EmbeddedModelField")
2222
self.assertEqual(args, [])
23-
self.assertEqual(kwargs, {"embedded_model": "EmbeddedModel", "null": True})
23+
self.assertEqual(kwargs, {"embedded_model": "Data", "null": True})
2424

2525
def test_get_db_prep_save_invalid(self):
26-
msg = (
27-
"Expected instance of type <class 'model_fields_.models.EmbeddedModel'>, "
28-
"not <class 'int'>."
29-
)
26+
msg = "Expected instance of type <class 'model_fields_.models.Data'>, " "not <class 'int'>."
3027
with self.assertRaisesMessage(TypeError, msg):
31-
EmbeddedModelFieldModel(simple=42).save()
28+
Holder(data=42).save()
3229

3330
def test_validate(self):
34-
obj = EmbeddedModelFieldModel(simple=EmbeddedModel(someint=None))
35-
# This isn't quite right because "someint" is the field that's non-null.
36-
msg = "{'simple': ['This field cannot be null.']}"
31+
obj = Holder(data=Data(integer=None))
32+
# This isn't quite right because "integer" is the field that's non-null.
33+
msg = "{'data': ['This field cannot be null.']}"
3734
with self.assertRaisesMessage(ValidationError, msg):
3835
obj.full_clean()
3936

@@ -44,74 +41,61 @@ def truncate_ms(self, value):
4441
return value.replace(microsecond=(value.microsecond // 1000) * 1000)
4542

4643
def test_save_load(self):
47-
EmbeddedModelFieldModel.objects.create(simple=EmbeddedModel(someint="5"))
48-
obj = EmbeddedModelFieldModel.objects.get()
49-
self.assertIsInstance(obj.simple, EmbeddedModel)
44+
Holder.objects.create(data=Data(integer="5"))
45+
obj = Holder.objects.get()
46+
self.assertIsInstance(obj.data, Data)
5047
# Make sure get_prep_value is called.
51-
self.assertEqual(obj.simple.someint, 5)
48+
self.assertEqual(obj.data.integer, 5)
5249
# Primary keys should not be populated...
53-
self.assertEqual(obj.simple.id, None)
50+
self.assertEqual(obj.data.id, None)
5451
# ... unless set explicitly.
55-
obj.simple.id = obj.id
52+
obj.data.id = obj.id
5653
obj.save()
57-
obj = EmbeddedModelFieldModel.objects.get()
58-
self.assertEqual(obj.simple.id, obj.id)
54+
obj = Holder.objects.get()
55+
self.assertEqual(obj.data.id, obj.id)
5956

6057
def test_save_load_null(self):
61-
EmbeddedModelFieldModel.objects.create(simple=None)
62-
obj = EmbeddedModelFieldModel.objects.get()
63-
self.assertIsNone(obj.simple)
58+
Holder.objects.create(data=None)
59+
obj = Holder.objects.get()
60+
self.assertIsNone(obj.data)
6461

6562
def test_pre_save(self):
6663
"""Field.pre_save() is called on embedded model fields."""
67-
obj = EmbeddedModelFieldModel.objects.create(simple=EmbeddedModel())
68-
auto_now = self.truncate_ms(obj.simple.auto_now)
69-
auto_now_add = self.truncate_ms(obj.simple.auto_now_add)
64+
obj = Holder.objects.create(data=Data())
65+
auto_now = self.truncate_ms(obj.data.auto_now)
66+
auto_now_add = self.truncate_ms(obj.data.auto_now_add)
7067
self.assertEqual(auto_now, auto_now_add)
7168
# save() updates auto_now but not auto_now_add.
7269
obj.save()
73-
self.assertEqual(self.truncate_ms(obj.simple.auto_now_add), auto_now_add)
74-
auto_now_two = obj.simple.auto_now
75-
self.assertGreater(auto_now_two, obj.simple.auto_now_add)
70+
self.assertEqual(self.truncate_ms(obj.data.auto_now_add), auto_now_add)
71+
auto_now_two = obj.data.auto_now
72+
self.assertGreater(auto_now_two, obj.data.auto_now_add)
7673
# And again, save() updates auto_now but not auto_now_add.
77-
obj = EmbeddedModelFieldModel.objects.get()
74+
obj = Holder.objects.get()
7875
obj.save()
79-
self.assertEqual(obj.simple.auto_now_add, auto_now_add)
80-
self.assertGreater(obj.simple.auto_now, auto_now_two)
76+
self.assertEqual(obj.data.auto_now_add, auto_now_add)
77+
self.assertGreater(obj.data.auto_now, auto_now_two)
8178

8279

8380
class QueryingTests(TestCase):
8481
@classmethod
8582
def setUpTestData(cls):
86-
cls.objs = [
87-
EmbeddedModelFieldModel.objects.create(simple=EmbeddedModel(someint=x))
88-
for x in range(6)
89-
]
83+
cls.objs = [Holder.objects.create(data=Data(integer=x)) for x in range(6)]
9084

9185
def test_exact(self):
92-
self.assertCountEqual(
93-
EmbeddedModelFieldModel.objects.filter(simple__someint=3), [self.objs[3]]
94-
)
86+
self.assertCountEqual(Holder.objects.filter(data__integer=3), [self.objs[3]])
9587

9688
def test_lt(self):
97-
self.assertCountEqual(
98-
EmbeddedModelFieldModel.objects.filter(simple__someint__lt=3), self.objs[:3]
99-
)
89+
self.assertCountEqual(Holder.objects.filter(data__integer__lt=3), self.objs[:3])
10090

10191
def test_lte(self):
102-
self.assertCountEqual(
103-
EmbeddedModelFieldModel.objects.filter(simple__someint__lte=3), self.objs[:4]
104-
)
92+
self.assertCountEqual(Holder.objects.filter(data__integer__lte=3), self.objs[:4])
10593

10694
def test_gt(self):
107-
self.assertCountEqual(
108-
EmbeddedModelFieldModel.objects.filter(simple__someint__gt=3), self.objs[4:]
109-
)
95+
self.assertCountEqual(Holder.objects.filter(data__integer__gt=3), self.objs[4:])
11096

11197
def test_gte(self):
112-
self.assertCountEqual(
113-
EmbeddedModelFieldModel.objects.filter(simple__someint__gte=3), self.objs[3:]
114-
)
98+
self.assertCountEqual(Holder.objects.filter(data__integer__gte=3), self.objs[3:])
11599

116100
def test_nested(self):
117101
obj = Book.objects.create(

0 commit comments

Comments
 (0)