Skip to content

Commit e526ab9

Browse files
committed
mock as needed
1 parent 1519e0f commit e526ab9

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

tests/utils_/test_parse_uri.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,13 @@ def setUp(self):
1616
self.mock_resolver = self.patcher.start()
1717
self.addCleanup(self.patcher.stop)
1818

19-
@patch("dns.resolver.resolve")
20-
def test_simple_uri(self, mock_resolver):
19+
def test_simple_uri(self):
2120
settings_dict = parse_uri("mongodb://cluster0.example.mongodb.net/myDatabase")
2221
self.assertEqual(settings_dict["ENGINE"], "django_mongodb")
2322
self.assertEqual(settings_dict["NAME"], "myDatabase")
2423
self.assertEqual(settings_dict["HOST"], "cluster0.example.mongodb.net")
2524

26-
@patch("dns.resolver.resolve")
27-
def test_no_database(self, mock_resolver):
25+
def test_no_database(self):
2826
settings_dict = parse_uri("mongodb://cluster0.example.mongodb.net/")
2927
self.assertEqual(settings_dict["ENGINE"], "django_mongodb")
3028
self.assertEqual(settings_dict["HOST"], "cluster0.example.mongodb.net")
@@ -65,26 +63,22 @@ def test_localhosts_with_ports(self):
6563
self.assertEqual(settings_dict["HOST"], "localhost:27017,localhost:27018,localhost:27019")
6664
self.assertEqual(settings_dict["PORT"], None)
6765

68-
@patch("dns.resolver.resolve")
69-
def test_conn_max_age(self, mock_resolver):
66+
def test_conn_max_age(self):
7067
settings_dict = parse_uri(URI, conn_max_age=600)
7168
self.assertEqual(settings_dict["CONN_MAX_AGE"], 600)
7269

73-
@patch("dns.resolver.resolve")
74-
def test_conn_health_checks(self, mock_resolver):
70+
def test_conn_health_checks(self):
7571
settings_dict = parse_uri(URI, conn_health_checks=True)
7672
self.assertEqual(settings_dict["CONN_HEALTH_CHECKS"], True)
7773

78-
@patch("dns.resolver.resolve")
79-
def test_test_kwarg(self, mock_resolver):
74+
def test_test_kwarg(self):
8075
settings_dict = parse_uri(URI, test={"NAME": "test_db"})
8176
self.assertEqual(settings_dict["TEST"]["NAME"], "test_db")
8277

8378
def test_invalid_credentials(self):
8479
with self.assertRaises(pymongo.errors.InvalidURI):
8580
parse_uri("mongodb://:@localhost/myDatabase")
8681

87-
@patch("dns.resolver.resolve")
88-
def test_no_prefix(self, mock_resolver):
82+
def test_no_prefix(self):
8983
with self.assertRaises(pymongo.errors.InvalidURI):
9084
parse_uri("cluster0.example.mongodb.net/myDatabase")

0 commit comments

Comments
 (0)