Skip to content

Commit eac06d1

Browse files
committed
Rename the delayed methods.
1 parent c035a6c commit eac06d1

File tree

1 file changed

+37
-41
lines changed

1 file changed

+37
-41
lines changed

tests/queries_/test_search.py

Lines changed: 37 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,9 @@ def wrapper(self, fetch, *args, **kwargs):
7272
class SearchUtilsMixin(TransactionTestCase):
7373
available_apps = ["queries_"]
7474

75-
delayedAssertCountEqual = _delayed_assertion(timeout=2)(TransactionTestCase.assertCountEqual)
76-
delayedAssertListEqual = _delayed_assertion(timeout=2)(TransactionTestCase.assertListEqual)
77-
delayedAssertQuerySetEqual = _delayed_assertion(timeout=2)(
78-
TransactionTestCase.assertQuerySetEqual
79-
)
75+
assertCountEqual = _delayed_assertion(timeout=2)(TransactionTestCase.assertCountEqual)
76+
assertListEqual = _delayed_assertion(timeout=2)(TransactionTestCase.assertListEqual)
77+
assertQuerySetEqual = _delayed_assertion(timeout=2)(TransactionTestCase.assertQuerySetEqual)
8078

8179
@staticmethod
8280
def _get_collection(model):
@@ -117,14 +115,14 @@ def setUp(self):
117115

118116
def test_search_equals(self):
119117
qs = Article.objects.annotate(score=SearchEquals(path="headline", value="cross"))
120-
self.delayedAssertCountEqual(qs, [self.article])
118+
self.assertCountEqual(qs, [self.article])
121119

122120
def test_boost_score(self):
123121
boost_score = SearchScoreOption({"boost": {"value": 3}})
124122
qs = Article.objects.annotate(
125123
score=SearchEquals(path="headline", value="cross", score=boost_score)
126124
)
127-
self.delayedAssertCountEqual(qs, [self.article])
125+
self.assertCountEqual(qs, [self.article])
128126
scored = qs.first()
129127
self.assertGreaterEqual(scored.score, 3.0)
130128

@@ -133,7 +131,7 @@ def test_constant_score(self):
133131
qs = Article.objects.annotate(
134132
score=SearchEquals(path="headline", value="cross", score=constant_score)
135133
)
136-
self.delayedAssertCountEqual(qs, [self.article])
134+
self.assertCountEqual(qs, [self.article])
137135
scored = qs.first()
138136
self.assertAlmostEqual(scored.score, 10.0, places=2)
139137

@@ -152,7 +150,7 @@ def test_function_score(self):
152150
qs = Article.objects.annotate(
153151
score=SearchEquals(path="headline", value="cross", score=function_score)
154152
)
155-
self.delayedAssertCountEqual(qs, [self.article])
153+
self.assertCountEqual(qs, [self.article])
156154
scored = qs.first()
157155
self.assertAlmostEqual(scored.score, 1.0, places=2)
158156

@@ -213,13 +211,13 @@ def test_search_autocomplete(self):
213211
fuzzy={"maxEdits": 2},
214212
)
215213
)
216-
self.delayedAssertCountEqual(qs.all, [self.article])
214+
self.assertCountEqual(qs.all, [self.article])
217215

218216
def test_search_autocomplete_embedded_model(self):
219217
qs = Article.objects.annotate(
220218
score=SearchAutocomplete(path="writer__name", query="Joselina")
221219
)
222-
self.delayedAssertCountEqual(qs.all, [self.article])
220+
self.assertCountEqual(qs.all, [self.article])
223221

224222
def test_constant_score(self):
225223
constant_score = SearchScoreOption({"constant": {"value": 10}})
@@ -232,7 +230,7 @@ def test_constant_score(self):
232230
score=constant_score,
233231
)
234232
)
235-
self.delayedAssertCountEqual(qs.all, [self.article])
233+
self.assertCountEqual(qs.all, [self.article])
236234
scored = qs.first()
237235
self.assertAlmostEqual(scored.score, 10.0, places=2)
238236

@@ -253,12 +251,12 @@ def setUp(self):
253251

254252
def test_search_exists(self):
255253
qs = Article.objects.annotate(score=SearchExists(path="body"))
256-
self.delayedAssertCountEqual(qs.all, [self.article])
254+
self.assertCountEqual(qs.all, [self.article])
257255

258256
def test_constant_score(self):
259257
constant_score = SearchScoreOption({"constant": {"value": 10}})
260258
qs = Article.objects.annotate(score=SearchExists(path="body", score=constant_score))
261-
self.delayedAssertCountEqual(qs.all, [self.article])
259+
self.assertCountEqual(qs.all, [self.article])
262260
scored = qs.first()
263261
self.assertAlmostEqual(scored.score, 10.0, places=2)
264262

@@ -280,14 +278,14 @@ def setUp(self):
280278

281279
def test_search_in(self):
282280
qs = Article.objects.annotate(score=SearchIn(path="headline", value=["cross", "river"]))
283-
self.delayedAssertCountEqual(qs.all, [self.article])
281+
self.assertCountEqual(qs.all, [self.article])
284282

285283
def test_constant_score(self):
286284
constant_score = SearchScoreOption({"constant": {"value": 10}})
287285
qs = Article.objects.annotate(
288286
score=SearchIn(path="headline", value=["cross", "river"], score=constant_score)
289287
)
290-
self.delayedAssertCountEqual(qs.all, [self.article])
288+
self.assertCountEqual(qs.all, [self.article])
291289
scored = qs.first()
292290
self.assertAlmostEqual(scored.score, 10.0, places=2)
293291

@@ -311,14 +309,14 @@ def setUp(self):
311309

312310
def test_search_phrase(self):
313311
qs = Article.objects.annotate(score=SearchPhrase(path="body", query="quick brown"))
314-
self.delayedAssertCountEqual(qs.all, [self.article])
312+
self.assertCountEqual(qs.all, [self.article])
315313

316314
def test_constant_score(self):
317315
constant_score = SearchScoreOption({"constant": {"value": 10}})
318316
qs = Article.objects.annotate(
319317
score=SearchPhrase(path="body", query="quick brown", score=constant_score)
320318
)
321-
self.delayedAssertCountEqual(qs.all, [self.article])
319+
self.assertCountEqual(qs.all, [self.article])
322320
scored = qs.first()
323321
self.assertAlmostEqual(scored.score, 10.0, places=2)
324322

@@ -340,14 +338,14 @@ def setUp(self):
340338

341339
def test_search_range(self):
342340
qs = Article.objects.annotate(score=SearchRange(path="number", gte=10, lt=30))
343-
self.delayedAssertCountEqual(qs.all, [self.number20])
341+
self.assertCountEqual(qs.all, [self.number20])
344342

345343
def test_constant_score(self):
346344
constant_score = SearchScoreOption({"constant": {"value": 10}})
347345
qs = Article.objects.annotate(
348346
score=SearchRange(path="number", gte=10, lt=30, score=constant_score)
349347
)
350-
self.delayedAssertCountEqual(qs.all, [self.number20])
348+
self.assertCountEqual(qs.all, [self.number20])
351349
scored = qs.first()
352350
self.assertAlmostEqual(scored.score, 10.0, places=2)
353351

@@ -376,7 +374,7 @@ def test_search_regex(self):
376374
qs = Article.objects.annotate(
377375
score=SearchRegex(path="headline", query="hello.*", allow_analyzed_field=True)
378376
)
379-
self.delayedAssertCountEqual(qs.all, [self.article])
377+
self.assertCountEqual(qs.all, [self.article])
380378

381379
def test_constant_score(self):
382380
constant_score = SearchScoreOption({"constant": {"value": 10}})
@@ -385,7 +383,7 @@ def test_constant_score(self):
385383
path="headline", query="hello.*", allow_analyzed_field=True, score=constant_score
386384
)
387385
)
388-
self.delayedAssertCountEqual(qs.all, [self.article])
386+
self.assertCountEqual(qs.all, [self.article])
389387
scored = qs.first()
390388
self.assertAlmostEqual(scored.score, 10.0, places=2)
391389

@@ -409,19 +407,19 @@ def setUp(self):
409407

410408
def test_search_text(self):
411409
qs = Article.objects.annotate(score=SearchText(path="body", query="lazy"))
412-
self.delayedAssertCountEqual(qs.all, [self.article])
410+
self.assertCountEqual(qs.all, [self.article])
413411

414412
def test_search_lookup(self):
415413
qs = Article.objects.filter(body__search="lazy")
416-
self.delayedAssertCountEqual(qs.all, [self.article])
414+
self.assertCountEqual(qs.all, [self.article])
417415

418416
def test_search_text_with_fuzzy_and_criteria(self):
419417
qs = Article.objects.annotate(
420418
score=SearchText(
421419
path="body", query="lazzy", fuzzy={"maxEdits": 2}, match_criteria="all"
422420
)
423421
)
424-
self.delayedAssertCountEqual(qs.all, [self.article])
422+
self.assertCountEqual(qs.all, [self.article])
425423

426424
def test_constant_score(self):
427425
constant_score = SearchScoreOption({"constant": {"value": 10}})
@@ -434,7 +432,7 @@ def test_constant_score(self):
434432
score=constant_score,
435433
)
436434
)
437-
self.delayedAssertCountEqual(qs.all, [self.article])
435+
self.assertCountEqual(qs.all, [self.article])
438436
scored = qs.first()
439437
self.assertAlmostEqual(scored.score, 10.0, places=2)
440438

@@ -461,14 +459,14 @@ def setUp(self):
461459

462460
def test_search_wildcard(self):
463461
qs = Article.objects.annotate(score=SearchWildcard(path="headline", query="dark-*"))
464-
self.delayedAssertCountEqual(qs.all, [self.article])
462+
self.assertCountEqual(qs.all, [self.article])
465463

466464
def test_constant_score(self):
467465
constant_score = SearchScoreOption({"constant": {"value": 10}})
468466
qs = Article.objects.annotate(
469467
score=SearchWildcard(path="headline", query="dark-*", score=constant_score)
470468
)
471-
self.delayedAssertCountEqual(qs.all, [self.article])
469+
self.assertCountEqual(qs.all, [self.article])
472470
scored = qs.first()
473471
self.assertAlmostEqual(scored.score, 10.0, places=2)
474472

@@ -508,7 +506,7 @@ def test_search_geo_shape(self):
508506
qs = Article.objects.annotate(
509507
score=SearchGeoShape(path="location", relation="within", geometry=polygon)
510508
)
511-
self.delayedAssertCountEqual(qs.all, [self.article])
509+
self.assertCountEqual(qs.all, [self.article])
512510

513511
def test_constant_score(self):
514512
polygon = {
@@ -521,7 +519,7 @@ def test_constant_score(self):
521519
path="location", relation="within", geometry=polygon, score=constant_score
522520
)
523521
)
524-
self.delayedAssertCountEqual(qs.all, [self.article])
522+
self.assertCountEqual(qs.all, [self.article])
525523
scored = qs.first()
526524
self.assertAlmostEqual(scored.score, 10.0, places=2)
527525

@@ -560,7 +558,7 @@ def test_search_geo_within(self):
560558
geo_object=polygon,
561559
)
562560
)
563-
self.delayedAssertCountEqual(qs.all, [self.article])
561+
self.assertCountEqual(qs.all, [self.article])
564562

565563
def test_constant_score(self):
566564
polygon = {
@@ -576,7 +574,7 @@ def test_constant_score(self):
576574
score=constant_score,
577575
)
578576
)
579-
self.delayedAssertCountEqual(qs.all, [self.article])
577+
self.assertCountEqual(qs.all, [self.article])
580578
scored = qs.first()
581579
self.assertAlmostEqual(scored.score, 10.0, places=2)
582580

@@ -619,9 +617,7 @@ def test_search_more_like_this(self):
619617
qs = Article.objects.annotate(score=SearchMoreLikeThis(documents=like_docs)).order_by(
620618
"score"
621619
)
622-
self.delayedAssertQuerySetEqual(
623-
qs.all, [self.article1, self.article2], lambda a: a.headline
624-
)
620+
self.assertQuerySetEqual(qs.all, [self.article1, self.article2], lambda a: a.headline)
625621

626622

627623
@skipUnlessDBFeature("supports_atlas_search")
@@ -682,14 +678,14 @@ def test_expression(self):
682678
)
683679

684680
qs = Article.objects.annotate(score=compound).order_by("score")
685-
self.delayedAssertCountEqual(qs.all, [self.exoplanet])
681+
self.assertCountEqual(qs.all, [self.exoplanet])
686682

687683
def test_operations(self):
688684
expr = SearchEquals(path="headline", value="space exploration") & ~SearchEquals(
689685
path="number", value=3
690686
)
691687
qs = Article.objects.annotate(score=expr)
692-
self.delayedAssertCountEqual(qs.all, [self.mars_mission, self.exoplanet])
688+
self.assertCountEqual(qs.all, [self.mars_mission, self.exoplanet])
693689

694690
def test_mixed_scores(self):
695691
boost_score = SearchScoreOption({"boost": {"value": 5}})
@@ -708,7 +704,7 @@ def test_mixed_scores(self):
708704
should=[should_expr],
709705
)
710706
qs = Article.objects.annotate(score=compound).order_by("-score")
711-
self.delayedAssertListEqual(lambda: list(qs.all()), [self.exoplanet, self.mars_mission])
707+
self.assertListEqual(lambda: list(qs.all()), [self.exoplanet, self.mars_mission])
712708
# Exoplanet should rank first because of the constant 20 bump.
713709
self.assertEqual(qs.first(), self.exoplanet)
714710

@@ -724,7 +720,7 @@ def test_operationss_with_function_score(self):
724720
) & ~SearchEquals(path="number", value=3)
725721

726722
qs = Article.objects.annotate(score=expr).order_by("-score")
727-
self.delayedAssertListEqual(lambda: list(qs.all()), [self.exoplanet, self.mars_mission])
723+
self.assertListEqual(lambda: list(qs.all()), [self.exoplanet, self.mars_mission])
728724
# Returns mars_mission (score≈1) and exoplanet (score≈2) then; exoplanet first.
729725
self.assertEqual(qs.first(), self.exoplanet)
730726

@@ -785,7 +781,7 @@ def test_multiple_vector_search(self):
785781

786782
def test_search_and_filter(self):
787783
qs = Article.objects.filter(headline__search="space exploration", number__gt=2)
788-
self.delayedAssertCountEqual(qs.all, [self.icy_moons])
784+
self.assertCountEqual(qs.all, [self.icy_moons])
789785

790786

791787
@skipUnlessDBFeature("supports_atlas_search")
@@ -833,4 +829,4 @@ def test_vector_search(self):
833829
limit=2,
834830
)
835831
qs = Article.objects.annotate(score=expr).order_by("-score")
836-
self.delayedAssertCountEqual(qs.all, [self.mars, self.cooking])
832+
self.assertCountEqual(qs.all, [self.mars, self.cooking])

0 commit comments

Comments
 (0)