correct ObjectIdAutoField.db_type() #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
reviewed
Sep 22, 2024
| @@ -32,7 +32,7 @@ def get_prep_value(self, value): | |||
| raise ValueError(f"Field '{self.name}' expected an ObjectId but got {value!r}.") from e | |||
|
|
|||
| def db_type(self, connection): | |||
| return "ObjectId" | |||
| return "objectId" | |||
There was a problem hiding this comment.
why does this need to get lowercased?
There was a problem hiding this comment.
To match what MongoDB requires. See the table on the page linked in the PR description.
WaVEV
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://www.mongodb.com/docs/manual/reference/operator/query/type/