Skip to content

add support for QuerySet.distinct() #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

add support for QuerySet.distinct() #167

merged 1 commit into from
Oct 22, 2024
+21 −39

Conversation

WaVEV
Copy link
Collaborator

@WaVEV WaVEV commented Oct 21, 2024 •
edited by timgraham
Loading

fixes #164

@WaVEV WaVEV requested a review from timgraham October 21, 2024 00:39
@timgraham timgraham changed the title Add support for query set.distinct() add support for QuerySet.distinct() Oct 21, 2024
timgraham
timgraham approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@timgraham timgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'll make the necessary edits here and on the Django fork.

@timgraham timgraham force-pushed the add-support-for-QuerySet.distinct() branch from a029054 to 5912149 Compare October 21, 2024 16:11
@timgraham
Copy link
Collaborator

Could you check the admin_filters tests added here as expected failures? I didn't confirm that distinct() is at fault and (if so) whether it should be a follow-up or part of this fix.

@WaVEV
Copy link
Collaborator Author

WaVEV commented Oct 21, 2024

Could you check the admin_filters tests added here as expected failures? I didn't confirm that distinct() is at fault and (if so) whether it should be a follow-up or part of this fix.

Didn't know that those test exists. So maybe this PR is not ready yet.

@timgraham timgraham force-pushed the add-support-for-QuerySet.distinct() branch from 5912149 to 0534f43 Compare October 22, 2024 18:18
@timgraham timgraham force-pushed the add-support-for-QuerySet.distinct() branch from 0534f43 to e04056e Compare October 22, 2024 19:56
@timgraham timgraham merged commit e04056e into mongodb:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgraham timgraham timgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for QuerySet.distinct()
2 participants
@WaVEV @timgraham