INTPYTHON-602 Fix loading of embedded model fields that use database converters #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaVEV
reviewed
May 5, 2025
| return None | ||
| # Apply database converters to each field of the embedded model. | ||
| for field in self.embedded_model._meta.fields: | ||
| expression = Col("", field) |
There was a problem hiding this comment.
🤔 I think an Expression(output_field=field) is a better approach, it is more minimalistic.
There was a problem hiding this comment.
I've amended this PR since the from_db_value() approach doesn't work for nested models.
There was a problem hiding this comment.
Can't remain what the old code looks like. is It fixed now?
There was a problem hiding this comment.
Reviewing the unit test, show that is working now.
There was a problem hiding this comment.
Got it. New converted is added that apply the needed converters.
WaVEV
previously approved these changes
May 5, 2025
…database converters
WaVEV
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.