Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

ajhuh-mdb
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb commented Feb 12, 2025

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit 233015c
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67ae18df901c600008d9a3a0
😎 Deploy Preview https://deploy-preview-612--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nvillahermosa-mdb nvillahermosa-mdb self-requested a review February 12, 2025 22:32
Copy link
Collaborator

@nvillahermosa-mdb nvillahermosa-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajhuh-mdb LGTM with one optional nit

Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the speedy turnaround! added a couple small changes

source/faq.txt Outdated

To learn more about permissable reads and writes during synchronization, see :ref:`c2c-reads-and-writes`.
``mongosync`` combines and reorders writes from the source to destination during
synchronization, and temporarily modifies collection characteristics. As a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

source/faq.txt Outdated
synchronization, and temporarily modifies collection characteristics. As a
result, ``mongosync`` can't guarantee that the destination matches the source,
including a stale version of the source, at any point in time when the sync is
running. To safely accept traffic to the destination cluster, wait for the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"running" -> "running, even if the sync is paused"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@ajhuh-mdb ajhuh-mdb force-pushed the DOCSP-47219-midsync-reads-faq branch from 5579a4b to 233015c Compare February 13, 2025 16:07
Copy link

@mvankeulen94 mvankeulen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@ajhuh-mdb ajhuh-mdb merged commit 6149617 into mongodb:master Feb 13, 2025
4 checks passed
Copy link

The backport to v1.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.9 v1.9
# Navigate to the new working tree
cd .worktrees/backport-v1.9
# Create a new branch
git switch --create backport-612-to-v1.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6149617fb5573b0ec01baa07274d2b6d0a2f2c26
# Push it to GitHub
git push --set-upstream origin backport-612-to-v1.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.9

Then, create a pull request where the base branch is v1.9 and the compare/head branch is backport-612-to-v1.9.

Copy link

The backport to v1.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.8 v1.8
# Navigate to the new working tree
cd .worktrees/backport-v1.8
# Create a new branch
git switch --create backport-612-to-v1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6149617fb5573b0ec01baa07274d2b6d0a2f2c26
# Push it to GitHub
git push --set-upstream origin backport-612-to-v1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.8

Then, create a pull request where the base branch is v1.8 and the compare/head branch is backport-612-to-v1.8.

Copy link

The backport to v1.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.10 v1.10
# Navigate to the new working tree
cd .worktrees/backport-v1.10
# Create a new branch
git switch --create backport-612-to-v1.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6149617fb5573b0ec01baa07274d2b6d0a2f2c26
# Push it to GitHub
git push --set-upstream origin backport-612-to-v1.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.10

Then, create a pull request where the base branch is v1.10 and the compare/head branch is backport-612-to-v1.10.

github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback

(cherry picked from commit 6149617)
ajhuh-mdb added a commit that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback

(cherry picked from commit 6149617)

Co-authored-by: Alison Huh <[email protected]>
ajhuh-mdb added a commit to ajhuh-mdb/docs-cluster-to-cluster-sync that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback
ajhuh-mdb added a commit to ajhuh-mdb/docs-cluster-to-cluster-sync that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback
ajhuh-mdb added a commit to ajhuh-mdb/docs-cluster-to-cluster-sync that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback
ajhuh-mdb added a commit that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback
ajhuh-mdb added a commit that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback
ajhuh-mdb added a commit that referenced this pull request Feb 13, 2025
* DOCSP-47219-midsync-reads

* active voice

* internal feedback

* MVK feedback
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants