Skip to content

Conversation

@mayaraman19
Copy link
Contributor

@mayaraman19 mayaraman19 commented Jan 22, 2025

DESCRIPTION

updates /query-with-natural-language/query-with-natural-language -> /query-with-natural-language, adds a redirect for this path, and adds dependency for vale checks

STAGING

https://deploy-preview-711--docs-compass.netlify.app/query-with-natural-language/

Mut output:

Redirect 301 /docs/compass/master/query-with-natural-language/query-with-natural-language/ https://www.mongodb.com/docs/compass/master/query-with-natural-language/
Redirect 301 /docs/compass/beta/query-with-natural-language/query-with-natural-language/ https://www.mongodb.com/docs/compass/beta/query-with-natural-language/
Redirect 301 /docs/compass/current/query-with-natural-language/query-with-natural-language/ https://www.mongodb.com/docs/compass/current/query-with-natural-language/

JIRA

https://jira.mongodb.org/browse/DOCSP-46667

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for docs-compass failed. Why did it fail? →

Name Link
🔨 Latest commit 5330151
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/67912380cbaef2000974301a

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of non-blocking nits!

config/redirects Outdated
[*]: docs/compass/${version}/command-line-options/ -> ${base}/current/settings/command-line-options/

# Repetitive file paths
[*]: docs/compass/${version}/query-with-natural-language/query-with-natural-language -> ${base}/${version}/query-with-natural-language
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non-blocker] just a heads up we want to make sure the file ends with a newline!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not showing it in github 😿 but i have added one

- name: checkout
uses: actions/checkout@master

- name: Install docutils
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non-blocker] just checking this belongs in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup! it's to stop the vale checks from automatically failing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf thanks for the confirm!

@mayaraman19 mayaraman19 changed the title DOCSP-46667: Repetitive file path: query natural language DOCSP-46667-Repetitive-file-path-query-natural-language Jan 22, 2025
@ajhuh-mdb ajhuh-mdb merged commit 25fb907 into mongodb:master Jan 22, 2025
1 check passed
@mayaraman19 mayaraman19 deleted the DOCSP-46667-repetitive branch January 22, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants