Skip to content

DOCSP-51351-reorganize-toc #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 7, 2025

Conversation

@shuangela shuangela changed the base branch from master to comp-cov July 3, 2025 15:45
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for docs-kotlin-sync ready!

Name Link
🔨 Latest commit ae0d562
🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin-sync/deploys/686c2e102d920300083073e2
😎 Deploy Preview https://deploy-preview-106--docs-kotlin-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

docs-builder-bot commented Jul 3, 2025

🔄 Deploy Preview for docs-kotlin-sync processing

Item Details
🔨 Latest Commit 551f22de3fd87d253dd1b38cab0e28bca77776a7
😎 Deploy Preview https://deploy-preview-106--docs-kotlin-sync.netlify.app
🔍 Build Logs View Logs

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comments! If you have questions about my feedback lmk

:titlesonly:
:maxdepth: 1

Connect with Stable API </connect/stable-api>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: based on the TOC spreadsheet, I think the TOC label should be "Stable API" and the page title "Connect with Stable API"

Suggested change
Connect with Stable API </connect/stable-api>
Stable API </connect/stable-api>

=================================
==============================
Indexes for Query Optimization
==============================
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: suggestion for the Indexes section in general: there isn't much guidance about the Indexes subpages in the spreadsheet, and most drivers just have a single Indexes page without nested pages. I think it's better to avoid L3 nesting in this section, so I moved everything to L2 for PHP. example

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a ticket up to reorganize the indexes content: https://jira.mongodb.org/browse/DOCSP-51438 to remove L2 pages. I agree with you that we don't want L3 nesting but I think that can be done with the other ticket.

Validate Driver Signatures </validate-signatures>
What's New </whats-new>
Reference </reference>
API Documentation </api>
Issues & Help </issues-and-help>
View the Source <https://github.com/mongodb/mongo-java-driver/tree/master/driver-kotlin-sync>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: looks like this was removed from TOC

Suggested change
View the Source <https://github.com/mongodb/mongo-java-driver/tree/master/driver-kotlin-sync>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed, but the node docs kept it: https://www.mongodb.com/docs/drivers/node/current/get-started/ and to my knowledge we don't want to remove content. We can discuss synchronously at our kickoff meeting!

@shuangela shuangela requested a review from norareidy July 7, 2025 20:11
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some last comments

@@ -21,9 +21,8 @@ Specialized Data Formats
:titlesonly:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: This page title can just be "Data Formats" according to the spreadsheet

Data Classes </data-formats/data-format-data-class>
Kotlin Serialization </data-formats/serialization>
Codecs </data-formats/codecs>
BSON </data-formats/bson>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I think BSON is fine as the TOC label, but the actual page title might need to be longer - "Work with BSON Data"?

.. _kotlin-sync-atlas-search:

================================
Run an Atlas Vector Search Query
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I:

Suggested change
Run an Atlas Vector Search Query
Run an Atlas Search Query

@shuangela shuangela merged commit 6dc5793 into mongodb:comp-cov Jul 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants