Skip to content

DOCSP-48166: Add async examples for Data Formats pages #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2025
Merged

DOCSP-48166: Add async examples for Data Formats pages #213

merged 6 commits into from
Mar 12, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Mar 11, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48166

Staging Links

  • data-formats/bson
  • data-formats/custom-types
  • data-formats/dates-and-times
  • data-formats/time-series

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Mar 11, 2025 •
    edited
    Loading

    ❌ Deploy Preview for docs-pymongo failed. Why did it fail? →

    Name Link
    🔨 Latest commit
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67d1ac38ea91210ab78dc0f2

    rustagir
    rustagir approved these changes Mar 11, 2025
    View reviewed changes
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    overall looks good, would be ideal to store in code files but maybe that is out of scope

    NoahStapp
    NoahStapp suggested changes Mar 12, 2025
    View reviewed changes
    @mcmorisi mcmorisi requested a review from NoahStapp March 12, 2025 13:36
    NoahStapp
    NoahStapp suggested changes Mar 12, 2025
    View reviewed changes
    source/data-formats/custom-types.txt Outdated
    collection = db.get_collection("test", codec_options=codec_options)
    await collection.insert_one({"num": DecimalInt("45.321")})

    my_doc = collection.find_one()
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Still missing the await here.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Whoops, will fix

    @mcmorisi mcmorisi requested a review from NoahStapp March 12, 2025 15:16
    @mcmorisi mcmorisi merged commit 02cb636 into mongodb:master Mar 12, 2025
    5 of 6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-48167-async-dataformats branch March 12, 2025 19:42
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    DOCSP-48166: Add async examples for Data Formats pages (#213)
    6597a97 
    (cherry picked from commit 02cb636)
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    DOCSP-48166: Add async examples for Data Formats pages (#213)
    3879f64 
    (cherry picked from commit 02cb636)
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    DOCSP-48166: Add async examples for Data Formats pages (#213)
    764c849 
    (cherry picked from commit 02cb636)
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    DOCSP-48166: Add async examples for Data Formats pages (#213)
    fcc75db 
    (cherry picked from commit 02cb636)
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    DOCSP-48166: Add async examples for Data Formats pages (#213)
    48f97bb 
    (cherry picked from commit 02cb636)
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    Revert "DOCSP-48166: Add async examples for Data Formats pages (#213)"
    eee114f 
    This reverts commit 6597a97.
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    Revert "DOCSP-48166: Add async examples for Data Formats pages (#213)"
    5c142a8 
    This reverts commit 3879f64.
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    Revert "DOCSP-48166: Add async examples for Data Formats pages (#213)"
    49ea4ca 
    This reverts commit 3879f64.
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    Revert "DOCSP-48166: Add async examples for Data Formats pages (#213)"
    1adc324 
    This reverts commit fcc75db.
    mcmorisi added a commit that referenced this pull request Mar 12, 2025
    @mcmorisi
    Revert "DOCSP-48166: Add async examples for Data Formats pages (#213)"
    ffb9b69 
    This reverts commit 48f97bb.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    2 more reviewers

    @NoahStapp NoahStapp NoahStapp approved these changes

    @rustagir rustagir rustagir approved these changes

    Reviewers whose approvals may not affect merge requirements
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mcmorisi @NoahStapp @rustagir