-
Notifications
You must be signed in to change notification settings - Fork 20
v4.13 Release #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.13 Release #266
Conversation
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
source/reference/migration.txt
Outdated
|
||
* - ``TestFindManyAndEmptyCursor`` | ||
- 74.074 MB/s | ||
- 112.490 MB/s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 112.490 MB/s | |
- 112.490 MB/s |
Performance Benchmarks | ||
~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
The following table shows the performance benchmarks for different tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A short blurb to explain that in almost every case, the new asynchronous API performs better seems helpful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I was just going to add a comment for the same thing
source/reference/migration.txt
Outdated
|
||
.. warning:: | ||
|
||
The {+driver-async+} driver does not support Tornado. | ||
The {+driver-async+} API does not support Tornado. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake on this earlier: the new API does support Tornado, as Tornado was made fully compatible in a release some time ago.
source/reference/migration.txt
Outdated
- ``AsyncCursor.each()`` does not exist in the {+driver-async+} driver. | ||
- ``MotorGridOut.stream_to_handler()`` does not exist in the {+driver-async+} driver. | ||
- ``AsyncCursor.to_list(0)`` is not valid in the {+driver-async+} driver. Use | ||
- ``AsyncCursor.each()`` does not exist in the {+driver-async+} api-root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ``AsyncCursor.each()`` does not exist in the {+driver-async+} api-root. | |
- ``AsyncCursor.each()`` does not exist in the {+driver-async+} API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Performance Benchmarks | ||
~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
The following table shows the performance benchmarks for different tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I was just going to add a comment for the same thing
source/reference/migration.txt
Outdated
|
||
The {+driver-async+} driver functions similarly to the Motor library, but allows | ||
The {+driver-async+} API functions similarly to the Motor library, but allows | ||
for improved latency and throughput due to directly using Python Asyncio instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit pick - "Asyncio" -> "asyncio"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to merge, once the comment is addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions:
source/reference/migration.txt
Outdated
|
||
The {+driver-async+} API is designed to be a replacement for the Motor | ||
library. Motor was created to provide support for Tornado, with asyncio support | ||
added later. Because of this, Motor provides full asyncio and Tornado support, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all mentions:
added later. Because of this, Motor provides full asyncio and Tornado support, | |
added later. Because of this, Motor provides full ``asyncio`` and Tornado support, |
source/reference/migration.txt
Outdated
but still relies on a thread pool to perform network operations. In some cases, | ||
this might lead to performance degradation when using the Motor library. To | ||
address this issue, the {+driver-async+} API implements asyncio support directly | ||
into {+driver-short+}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: the comments below. I would mention in this intro paragraph that PyMongo Async has better performance in most cases, then link to the performance section.
source/reference/migration.txt
Outdated
{+driver-async+} API. We strongly recommend that Motor users migrate to | ||
the {+driver-async+} API while Motor is still supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a date
source/reference/release-notes.txt
Outdated
- The {+driver-async+} API is generally available. To learn how to migrate | ||
to the {+driver-async+} API, see the :ref:`pymongo-async-migration` guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The {+driver-async+} API is generally available. To learn how to migrate | |
to the {+driver-async+} API, see the :ref:`pymongo-async-migration` guide. | |
- The {+driver-async+} API is generally available. To learn how to migrate | |
to the {+driver-async+} API from the {+driver-short+} driver or the Motor library, see the :ref:`pymongo-async-migration` guide. |
Pull Request Info
PR Reviewing Guidelines
JIRA -
Staging Links
Self-Review Checklist