CLOUDP-78002: adds support for Atlas Error codes (#157)

Author: Anton

mongodbatlas/mongodbatlas.go

@@ -146,8 +146,12 @@ type ListOptions struct {
 type ErrorResponse struct {
 	// HTTP response that caused this error
 	Response *http.Response
-	// The error code, which is simply the HTTP status code.
-	ErrorCode int `json:"Error"`
+
+	// The error code as specified in https://docs.atlas.mongodb.com/reference/api/api-errors/
+	ErrorCode string `json:"errorCode"`
+
+	// HTTP status code.
+	HTTPCode int `json:"error"`
 
 	// A short description of the error, which is simply the HTTP status phrase.
 	Reason string `json:"reason"`
@@ -421,7 +425,7 @@ func (c *Client) Do(ctx context.Context, req *http.Request, v interface{}) (*Res
 
 func (r *ErrorResponse) Error() string {
 	return fmt.Sprintf("%v %v: %d (request %q) %v",
-		r.Response.Request.Method, r.Response.Request.URL, r.Response.StatusCode, r.Reason, r.Detail)
+		r.Response.Request.Method, r.Response.Request.URL, r.Response.StatusCode, r.ErrorCode, r.Detail)
 }
 
 // CheckResponse checks the API response for errors, and returns them if present. A response is considered an

mongodbatlas/mongodbatlas_test.go

@@ -360,7 +360,11 @@ func TestCheckResponse(t *testing.T) {
 	res := &http.Response{
 		Request:    &http.Request{},
 		StatusCode: http.StatusBadRequest,
-		Body:       ioutil.NopCloser(strings.NewReader(`{"error":400, "reason":"r", "detail":"d"}`)),
+		Body: ioutil.NopCloser(
+			strings.NewReader(
+				`{"error":409, "errorCode": "GROUP_ALREADY_EXISTS", "reason":"Conflict", "detail":"A group with name \"Test\" already exists"}`,
+			),
+		),
 	}
 	err := CheckResponse(res).(*ErrorResponse)
 
@@ -370,9 +374,10 @@ func TestCheckResponse(t *testing.T) {
 
 	expected := &ErrorResponse{
 		Response:  res,
-		ErrorCode: 400,
-		Reason:    "r",
-		Detail:    "d",
+		HTTPCode:  409,
+		ErrorCode: "GROUP_ALREADY_EXISTS",
+		Reason:    "Conflict",
+		Detail:    `A group with name "Test" already exists`,
 	}
 	if !reflect.DeepEqual(err, expected) {
 		t.Errorf("Error = %#v, expected %#v", err, expected)