Improve Makefile

- Check fmt using golangci
- Proerly install golangci
- Fix error when `make build`

Author: gssbzn

.gitignore

@@ -20,7 +20,6 @@ website/node_modules
 .idea
 *.iml
 *.test
-*.iml
 log.txt
 vendor/
 .vscode/

.travis.yml

@@ -21,6 +21,3 @@ matrix:
   - go: "1.12.x"
     name: "Code UnitTest"
     script: make test
-
-env:
-  - GO111MODULE=on

GNUmakefile

@@ -1,28 +1,27 @@
 TEST?=./...
 PKG_NAME=mongodbatlas
+export GO111MODULE := on
+export PATH := ./bin:$(PATH)
 
 default: build
 
-build: fmtcheck
-	go install
+build:
+	go install ./$(PKG_NAME)
 
-
-test: fmtcheck
+test:
 	go test $(TEST) -timeout=30s -parallel=4 -cover
 
 fmt:
 	@echo "==> Fixing source code with gofmt..."
 	gofmt -s -w ./$(PKG_NAME)
 
-fmtcheck:
-	@sh -c "'$(CURDIR)/scripts/gofmtcheck.sh'"
-
 lint:
 	@echo "==> Checking source code against linters..."
-	@GOGC=30 golangci-lint run ./$(PKG_NAME)
+	golangci-lint run $(TEST) -E gofmt
 
-tools:
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint
+check: test lint
 
+tools:
+	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s v1.21.0
 
-.PHONY: build test fmt fmtcheck lint tools
+.PHONY: build test fmt lint check tools

README.md

@@ -37,7 +37,7 @@ import (
 	"log"
 	"os"
 
-	digest "github.com/Sectorbob/mlab-ns2/gae/ns/digest"
+    "github.com/Sectorbob/mlab-ns2/gae/ns/digest"
 	"github.com/mongodb/go-client-mongodb-atlas/mongodbatlas"
 )
 
@@ -87,13 +87,12 @@ Each version of the client is tagged and the version is updated accordingly.
 To see the list of past versions, run `git tag`.
 
 
-
 ## Development and contribution
 
 Feel free to open an Issue or PR! Our contribution guidelines are a WIP but generally follow the official [Terraform Guidelines](https://www.terraform.io/docs/extend/community/contributing.html).
 
 ```
 git clone [email protected]:mongodb/go-client-mongodb-atlas.git
 make tools
-make test
-```
+make check
+```