fix: fix username path escape for db username (#199)

Author: gssbzn

mongodbatlas/database_users.go

@@ -18,6 +18,7 @@ import (
 	"context"
 	"fmt"
 	"net/http"
+	"net/url"
 )
 
 const dbUsersBasePath = "groups/%s/databaseUsers"
@@ -115,6 +116,9 @@ type databaseUsers struct {
 //
 // See more: https://docs.atlas.mongodb.com/reference/api/database-users-get-all-users/
 func (s *DatabaseUsersServiceOp) List(ctx context.Context, groupID string, listOptions *ListOptions) ([]DatabaseUser, *Response, error) {
+	if groupID == "" {
+		return nil, nil, NewArgError("groupID", "must be set")
+	}
 	path := fmt.Sprintf(dbUsersBasePath, groupID)
 
 	// Add query params from listOptions
@@ -156,7 +160,8 @@ func (s *DatabaseUsersServiceOp) Get(ctx context.Context, databaseName, groupID,
 	}
 
 	basePath := fmt.Sprintf(dbUsersBasePath, groupID)
-	path := fmt.Sprintf("%s/%s/%s", basePath, databaseName, username)
+	escapedEntry := url.PathEscape(username)
+	path := fmt.Sprintf("%s/%s/%s", basePath, databaseName, escapedEntry)
 
 	req, err := s.Client.NewRequest(ctx, http.MethodGet, path, nil)
 	if err != nil {
@@ -176,6 +181,9 @@ func (s *DatabaseUsersServiceOp) Get(ctx context.Context, databaseName, groupID,
 //
 // See more: https://docs.atlas.mongodb.com/reference/api/database-users-create-a-user/
 func (s *DatabaseUsersServiceOp) Create(ctx context.Context, groupID string, createRequest *DatabaseUser) (*DatabaseUser, *Response, error) {
+	if groupID == "" {
+		return nil, nil, NewArgError("groupID", "must be set")
+	}
 	if createRequest == nil {
 		return nil, nil, NewArgError("createRequest", "cannot be nil")
 	}
@@ -200,13 +208,21 @@ func (s *DatabaseUsersServiceOp) Create(ctx context.Context, groupID string, cre
 //
 // See more: https://docs.atlas.mongodb.com/reference/api/database-users-update-a-user/
 func (s *DatabaseUsersServiceOp) Update(ctx context.Context, groupID, username string, updateRequest *DatabaseUser) (*DatabaseUser, *Response, error) {
+	if groupID == "" {
+		return nil, nil, NewArgError("groupID", "must be set")
+	}
+	if username == "" {
+		return nil, nil, NewArgError("username", "must be set")
+	}
 	if updateRequest == nil {
 		return nil, nil, NewArgError("updateRequest", "cannot be nil")
 	}
 
 	basePath := fmt.Sprintf(dbUsersBasePath, groupID)
 
-	path := fmt.Sprintf("%s/%s/%s", basePath, updateRequest.GetAuthDB(), username)
+	escapedEntry := url.PathEscape(username)
+
+	path := fmt.Sprintf("%s/%s/%s", basePath, updateRequest.GetAuthDB(), escapedEntry)
 
 	req, err := s.Client.NewRequest(ctx, http.MethodPatch, path, updateRequest)
 	if err != nil {
@@ -237,7 +253,8 @@ func (s *DatabaseUsersServiceOp) Delete(ctx context.Context, databaseName, group
 	}
 
 	basePath := fmt.Sprintf(dbUsersBasePath, groupID)
-	path := fmt.Sprintf("%s/%s/%s", basePath, databaseName, username)
+	escapedEntry := url.PathEscape(username)
+	path := fmt.Sprintf("%s/%s/%s", basePath, databaseName, escapedEntry)
 
 	req, err := s.Client.NewRequest(ctx, http.MethodDelete, path, nil)
 	if err != nil {