Skip to content

Commit 6ecd527

Browse files
committed
fix: review-fix
1 parent 9a5d6c2 commit 6ecd527

File tree

1 file changed

+7
-18
lines changed

1 file changed

+7
-18
lines changed

tests/ModelTest.php

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -87,27 +87,22 @@ public function testQualifyColumn(): void
8787
$this->assertEquals('users.name', $sqlUser->qualifyColumn('name'));
8888
}
8989

90-
private function makeUser(array $overrides = []): User
90+
private function makeUser(): User
9191
{
92-
$defaults = [
93-
'name' => 'John Doe',
94-
'title' => 'admin',
95-
'age' => 35,
96-
];
97-
9892
$user = new User();
99-
foreach (array_merge($defaults, $overrides) as $key => $value) {
100-
$user->$key = $value;
101-
}
93+
$user->name = 'John Doe';
94+
$user->title = 'admin';
95+
$user->age = 35;
96+
97+
$user->save();
98+
10299
return $user;
103100
}
104101

105102
public function testInsert(): void
106103
{
107104
$user = $this->makeUser();
108105

109-
$user->save();
110-
111106
$this->assertTrue($user->exists);
112107
$this->assertEquals(1, User::count());
113108

@@ -127,7 +122,6 @@ public function testInsert(): void
127122
public function testUpdate(): void
128123
{
129124
$user = $this->makeUser();
130-
$user->save();
131125

132126
$raw = $user->getAttributes();
133127
$this->assertInstanceOf(ObjectID::class, $raw['id']);
@@ -243,7 +237,6 @@ public function testManualIntId(): void
243237
public function testDelete(): void
244238
{
245239
$user = $this->makeUser();
246-
$user->save();
247240

248241
$this->assertTrue($user->exists);
249242
$this->assertEquals(1, User::count());
@@ -256,7 +249,6 @@ public function testDelete(): void
256249
public function testAll(): void
257250
{
258251
$user = $this->makeUser();
259-
$user->save();
260252

261253
$user = new User();
262254
$user->name = 'Jane Doe';
@@ -274,7 +266,6 @@ public function testAll(): void
274266
public function testFind(): void
275267
{
276268
$user = $this->makeUser();
277-
$user->save();
278269

279270
$check = User::find($user->id);
280271
$this->assertInstanceOf(User::class, $check);
@@ -354,7 +345,6 @@ public function testCreate(): void
354345
public function testDestroy(): void
355346
{
356347
$user = $this->makeUser();
357-
$user->save();
358348

359349
User::destroy((string) $user->id);
360350

@@ -364,7 +354,6 @@ public function testDestroy(): void
364354
public function testTouch(): void
365355
{
366356
$user = $this->makeUser();
367-
$user->save();
368357

369358
$old = $user->updated_at;
370359
sleep(1);

0 commit comments

Comments
 (0)