#1930 update parameter type

Author: Treggats

src/Relations/EmbedsMany.php

@@ -9,6 +9,7 @@
 use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Pagination\Paginator;
 use MongoDB\BSON\ObjectID;
+use MongoDB\Laravel\Eloquent\Model as MongoDBModel;
 
 use function array_key_exists;
 use function array_values;
@@ -195,9 +196,11 @@ public function destroy($ids = [])
     /**
      * Delete all embedded models.
      *
+     * @param null $id
+     *
      * @return int
      */
-    public function delete()
+    public function delete($id = null)
     {
         // Overwrite the local key with an empty array.
         $result = $this->query->update([$this->localKey => []]);
@@ -224,9 +227,9 @@ public function detach($ids = [])
     /**
      * Save alias.
      *
-     * @return Model
+     * @return MongoDBModel
      */
-    public function attach(Model $model)
+    public function attach(MongoDBModel $model)
     {
         return $this->save($model);
     }

src/Relations/EmbedsOne.php

@@ -133,9 +133,11 @@ public function dissociate()
     /**
      * Delete all embedded models.
      *
+     * @param ?string $id
+     *
      * @return int
      */
-    public function delete()
+    public function delete($id = null)
     {
         return $this->performDelete();
     }

src/Relations/EmbedsOneOrMany.php

@@ -8,6 +8,7 @@
 use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Model as EloquentModel;
 use Illuminate\Database\Eloquent\Relations\Relation;
+use Illuminate\Database\Query\Expression;
 use MongoDB\Laravel\Eloquent\Model;
 
 use function array_merge;
@@ -99,9 +100,11 @@ public function get($columns = ['*'])
     /**
      * Get the number of embedded models.
      *
+     * @param Expression|string $columns
+     *
      * @return int
      */
-    public function count()
+    public function count($columns = '*')
     {
         return count($this->getEmbedded());
     }
@@ -392,8 +395,8 @@ public function getQualifiedForeignKeyName()
     /**
      * Get the name of the "where in" method for eager loading.
      *
-     * @param  \Illuminate\Database\Eloquent\Model $model
-     * @param  string                              $key
+     * @param EloquentModel $model
+     * @param  string        $key
      *
      * @return string
      */