#1930 add parent call and simplify setting the properties

Treggats · Treggats · commit ad339b919b20 · 2023-11-04T01:43:32.000+01:00
diff --git a/src/Relations/EmbedsOneOrMany.php b/src/Relations/EmbedsOneOrMany.php
@@ -42,8 +42,8 @@ abstract class EmbedsOneOrMany extends Relation
      */
     public function __construct(Builder $query, Model $parent, Model $related, string $localKey, string $foreignKey, string $relation)
     {
-        $this->query      = $query;
-        $this->parent     = $parent;
+        parent::__construct($query, $parent);
+
         $this->related    = $related;
         $this->localKey   = $localKey;
         $this->foreignKey = $foreignKey;
@@ -54,8 +54,6 @@ public function __construct(Builder $query, Model $parent, Model $related, strin
         if ($parentRelation) {
             $this->query = $parentRelation->getQuery();
         }
-
-        $this->addConstraints();
     }
 
     /** @inheritdoc */

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,8 @@ abstract class EmbedsOneOrMany extends Relation`
`42`	`42`	`*/`
`43`	`43`	`public function __construct(Builder $query, Model $parent, Model $related, string $localKey, string $foreignKey, string $relation)`
`44`	`44`	`{`
`45`		`- $this->query = $query;`
`46`		`- $this->parent = $parent;`
	`45`	`+ parent::__construct($query, $parent);`
	`46`	`+`
`47`	`47`	`$this->related = $related;`
`48`	`48`	`$this->localKey = $localKey;`
`49`	`49`	`$this->foreignKey = $foreignKey;`
`@@ -54,8 +54,6 @@ public function __construct(Builder $query, Model $parent, Model $related, strin`
`54`	`54`	`if ($parentRelation) {`
`55`	`55`	`$this->query = $parentRelation->getQuery();`
`56`	`56`	`}`
`57`		`-`
`58`		`- $this->addConstraints();`
`59`	`57`	`}`
`60`	`58`
`61`	`59`	`/** @inheritdoc */`