Merge pull request #1740 from jim5359/EmbedsMany-primaryKey-fix

jenssegers · web-flow · commit f3f230a95bef · 2019-09-12T22:08:17.000+02:00
EmbedsMany respect primaryKey on association
diff --git a/src/Jenssegers/Mongodb/Relations/EmbedsMany.php b/src/Jenssegers/Mongodb/Relations/EmbedsMany.php
@@ -227,7 +227,7 @@ public function attach(Model $model)
     protected function associateNew($model)
     {
         // Create a new key if needed.
-        if (!$model->getAttribute('_id')) {
+        if ($model->getKeyName() === '_id' && !$model->getAttribute('_id')) {
             $model->setAttribute('_id', new ObjectID);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ public function attach(Model $model)`
`227`	`227`	`protected function associateNew($model)`
`228`	`228`	`{`
`229`	`229`	`// Create a new key if needed.`
`230`		`- if (!$model->getAttribute('_id')) {`
	`230`	`+ if ($model->getKeyName() === '_id' && !$model->getAttribute('_id')) {`
`231`	`231`	`$model->setAttribute('_id', new ObjectID);`
`232`	`232`	`}`
`233`	`233`