Skip to content

Commit 0700607

Browse files
authored
LG-5476: Updates InfoSprinkleProps (#3130)
* updates infosprinkle props * rm fixme * Update cyan-walls-sell.md
1 parent cfab277 commit 0700607

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

.changeset/cyan-walls-sell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/info-sprinkle': patch
3+
---
4+
5+
`children` is now a required property

packages/info-sprinkle/src/InfoSprinkle/InfoSprinkle.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ describe('packages/info-sprinkle', () => {
104104
// eslint-disable-next-line jest/no-disabled-tests
105105
test.skip('types behave as expected', () => {
106106
<>
107-
{/* FIXME: add expect error @ts-expect-error - Missing children */}
107+
{/* @ts-expect-error - Missing children */}
108108
<InfoSprinkle />
109109

110110
<InfoSprinkle>Tooltip</InfoSprinkle>

packages/info-sprinkle/src/InfoSprinkle/InfoSprinkle.types.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ export { Align, Justify };
66

77
type ModifiedTooltipProps = Omit<
88
TooltipProps,
9+
| 'children'
910
| 'dismissMode'
1011
| 'onClick'
1112
| 'popoverZIndex'
@@ -25,4 +26,9 @@ export interface InfoSprinkleProps extends ModifiedTooltipProps {
2526
* Trigger props, excludes `ref`
2627
*/
2728
triggerProps?: Omit<ComponentProps<'button'>, 'ref'>;
29+
30+
/**
31+
* Children of the InfoSprinkle
32+
*/
33+
children: React.ReactNode;
2834
}

0 commit comments

Comments
 (0)