LG-3497: ThumbUp and ThumbDown icon - dark mode (#1914)

spark33 · bruugey · web-flow · commit 31c093549693 · 2023-08-10T12:54:34.000-04:00
Co-authored-by: Brooke Scarlett Yalof &lt;brooke.yalof@mongodb.com&gt;
diff --git a/.changeset/shy-penguins-chew.md b/.changeset/shy-penguins-chew.md
@@ -0,0 +1,5 @@
+---
+'@leafygreen-ui/icon': patch
+---
+
+Fixing issue where dark mode would not change ThumbsUp and ThumbsDown icon fills
diff --git a/packages/icon/README.md b/packages/icon/README.md
@@ -149,7 +149,7 @@ A `LGGlyph.Component`
 
 (For DS engineers)
 
-- After uploading a new SVG file to `src/glyphs`, replace all `fill` property values with `#000`.
+- After uploading a new SVG file to `src/glyphs`, replace all `fill` property values for strokes with `#000`.
 - Update `src/glyphs/index.ts` to import/export the SVG file.
 - Build the package with `yarn build:packages icon` to create the component in `src/generated`.
 - Update README
diff --git a/packages/icon/src/generated/ThumbsDown.tsx b/packages/icon/src/generated/ThumbsDown.tsx
diff --git a/packages/icon/src/generated/ThumbsUp.tsx b/packages/icon/src/generated/ThumbsUp.tsx
diff --git a/packages/icon/src/glyphs/ThumbsDown.svg b/packages/icon/src/glyphs/ThumbsDown.svg
@@ -1,3 +1,3 @@
-<svg width="16" height="16" viewBox="0 0 16 16" fill="#000" xmlns="http://www.w3.org/2000/svg">
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
 <path fill-rule="evenodd" clip-rule="evenodd" d="M8.01852 15C8.53023 15 8.99812 14.7199 9.22744 14.2764L11.728 9.43945C11.7542 9.38879 11.7773 9.33683 11.7972 9.28386C11.8277 9.28652 11.8584 9.28788 11.8896 9.28788L13.9843 9.28788C14.5453 9.28788 15 8.84694 15 8.30303L15 3.18182C15 2.6379 14.5453 2 13.9844 2L11.8896 2C11.6144 2 11 2 11 2C11 2 10.3639 2 9.85827 2L3.99311 2C3.02273 2 2.18787 2.66552 2.00017 3.5887L1.03904 8.31597C0.791531 9.53331 1.7524 10.6667 3.03198 10.6667L5.31958 10.6667L5.31958 12.3829C5.31958 13.8283 6.52794 15 8.01852 15ZM9.85827 8.66091L7.65371 12.9252C7.47137 12.8096 7.35088 12.6099 7.35088 12.3829L7.35088 10.0758C7.35088 9.31427 6.71427 8.69697 5.92897 8.69697L3.64387 8.69697C3.32769 8.69697 3.09089 8.40718 3.15389 8.09735L3.9117 4.37008C3.95907 4.1371 4.16394 3.9697 4.40168 3.9697L9.85827 3.9697L9.85827 8.66091Z" fill="#000"/>
 </svg>
diff --git a/packages/icon/src/glyphs/ThumbsUp.svg b/packages/icon/src/glyphs/ThumbsUp.svg
@@ -1,3 +1,3 @@
-<svg width="16" height="16" viewBox="0 0 16 16" fill="#000" xmlns="http://www.w3.org/2000/svg">
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
 <path fill-rule="evenodd" clip-rule="evenodd" d="M7.98148 1C7.46977 1 7.00188 1.28007 6.77256 1.72365L4.27198 6.56054C4.24579 6.61121 4.22269 6.66317 4.20275 6.71614C4.17234 6.71348 4.14155 6.71212 4.11043 6.71212H2.01565C1.45472 6.71212 1 7.15306 1 7.69697V12.8182C1 13.3621 1.45472 14 2.01565 14H4.11043C4.38564 14 5 14 5 14C5 14 5.63614 14 6.14173 14H12.0069C12.9773 14 13.8121 13.3345 13.9998 12.4113L14.961 7.68402C15.2085 6.46669 14.2476 5.33333 12.968 5.33333H10.6804V3.61709C10.6804 2.17171 9.47206 1 7.98148 1ZM6.14173 7.33909L8.34629 3.0748C8.52863 3.19038 8.64912 3.39009 8.64912 3.61709V5.92424C8.64912 6.68572 9.28573 7.30303 10.071 7.30303H12.3561C12.6723 7.30303 12.9091 7.59282 12.8461 7.90265L12.0883 11.6299C12.0409 11.8629 11.8361 12.0303 11.5983 12.0303L6.14173 12.0303V7.33909Z" fill="#000"/>
 </svg>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@leafygreen-ui/icon': patch
 +---
++
 +Fixing issue where dark mode would not change ThumbsUp and ThumbsDown icon fills