fix: adjust testing bundle creation

Author: nima-taheri-mongodb

tools/build/config/rollup.config.mjs

@@ -14,7 +14,7 @@ import { getUMDGlobals } from './utils/getUMDGlobals.mjs';
 import { defaultsDeep } from 'lodash-es';
 
 const extensions = ['.ts', '.tsx'];
-const testUtilsFilename = 'src/testing/index.ts';
+const testBundleGlob = 'src/testing/index.ts';
 const storyGlob = 'src/*.stor{y,ies}.tsx';
 
 const babelConfigPath = fileURLToPath(
@@ -33,22 +33,27 @@ const moduleFormatToDirectory = {
   umd: 'dist/umd',
 };
 
-const doTestUtilsExist = glob.sync(testUtilsFilename).length > 0;
-
 /**
- * @param {{ format: import('rollup').OutputOptions['format'], useTerser?: boolean, outputNameSuffix?: string }} options
+ * @param {{ format: import('rollup').OutputOptions['format'], useTerser?: boolean, outputFile?: string, outputName?: string, outputDir?: string }} options
  * @returns {import('rollup').OutputOptions}
  */
-const createOutput = ({ format, useTerser = false, outputNameSuffix = '' }) => {
+const createOutput = ({
+  format,
+  useTerser = false,
+  outputFile = undefined,
+  outputName = '[name].js',
+  outputDir = moduleFormatToDirectory[format],
+}) => {
   return {
-    dir: moduleFormatToDirectory[format],
+    dir: outputDir,
+    file: outputFile,
     name,
     format,
     sourcemap: true,
     globals: format === 'umd' ? getUMDGlobals() : {},
     validate: true,
     interop: 'compat', // https://rollupjs.org/configuration-options/#output-interop
-    entryFileNames: `[name]${outputNameSuffix}.js`,
+    entryFileNames: outputName,
     plugins: useTerser ? [terser()] : [],
   };
 };
@@ -92,6 +97,7 @@ const createConfigForFormat = (output, overrides = {}) => {
   return finalConfig;
 };
 
+// 1. Create the default esm/umd bundles configs
 const esmConfig = createConfigForFormat(
   createOutput({ format: 'esm', useTerser: true }),
 );
@@ -101,57 +107,74 @@ const umdConfig = createConfigForFormat(
 
 const defaultConfig = [esmConfig, umdConfig];
 
-// configurations for modern dev/prod bundle publishing
-// to be used by packages that are included in the experiment
+// 1.1. Create the modern dev/prod bundle configs
 const modernDevProdConfig = createConfigForFormat([
   createOutput({ format: 'esm' }),
   createOutput({ format: 'umd' }),
   createOutput({
     format: 'esm',
     useTerser: true,
-    outputNameSuffix: '-min',
+    outputName: '[name]-min.js',
   }),
   createOutput({
     format: 'umd',
     useTerser: true,
-    outputNameSuffix: '-min',
+    outputName: '[name]-min.js',
   }),
 ]);
 
-// Add additional entry point to UMD build for test-utils if they exist
-doTestUtilsExist &&
+// 2. Create testing bundles (if applicable)
+const testingBundleEntryPoints = glob.sync(testBundleGlob);
+
+if (testingBundleEntryPoints.length > 0) {
   defaultConfig.push(
-    createConfigForFormat('esm', {
-      input: testUtilsFilename,
-      output: {
-        dir: `${moduleFormatToDirectory['esm']}/testing`,
+    createConfigForFormat(
+      createOutput({
+        format: 'esm',
+        useTerser: true,
+        outputDir: `${moduleFormatToDirectory['esm']}/testing`,
+      }),
+      {
+        input: testingBundleEntryPoints,
       },
-    }),
-    createConfigForFormat('umd', {
-      input: testUtilsFilename,
-      output: {
-        dir: `${moduleFormatToDirectory['umd']}/testing`,
+    ),
+    createConfigForFormat(
+      createOutput({
+        format: 'umd',
+        useTerser: true,
+        outputDir: `${moduleFormatToDirectory['umd']}/testing`,
+      }),
+      {
+        input: testingBundleEntryPoints,
       },
-    }),
+    ),
   );
+}
+
+// 3. Create stories bundles (if applicable)
+
+const storiesEntryPoints = glob.sync(storyGlob);
 
 // FIXME: Figure out a way to get rid of this.
 // Creates a super-hacky `stories` bundle
-const storiesExist = glob.sync(storyGlob).length > 0;
-
-/** @type {import('rollup').RollupOptions} */
-const storiesConfig = {
-  ...esmConfig,
-  input: glob.sync(storyGlob)[0],
-  output: {
-    format: 'esm',
-    file: 'stories.js',
+const storiesConfig = createConfigForFormat(
+  {
+    ...createOutput({
+      format: 'esm',
+      useTerser: true,
+      outputDir: null,
+      outputFile: 'stories.js',
+    }),
     sourcemap: false,
-    globals: esmConfig.output.globals,
   },
-};
+  {
+    input: storiesEntryPoints[0],
+  },
+);
 
-storiesExist && defaultConfig.push(storiesConfig);
+if (storiesEntryPoints.length > 0) {
+  defaultConfig.push(storiesConfig);
+}
 
 export { modernDevProdConfig, esmConfig, storiesConfig, umdConfig };