Skip to content

Commit 4fcf2e9

Browse files
shaneezashaneeza
authored
React18_integration_FINAL_v3 (#1926)
* adding back everything * update mdx-js package, update storybook peerDep react version * React.PropsWithChildren changeset * add transition changeset * formfooter changeset * guidecue changeset * lib changeset * modal changeset * numberInput changeset * remove position utils exports * portal changeset * revert search-input change * segmented-control changeset * side-nav changeset * guide-cue and side-nav changeset tweaks * side nav cs updates * add ticket to fail table skeleton test * table changeset * tooltip changeset * typo * changeset changes and modal changes * portal patch to major * fix some combobox tests * remove PropsWithChildren from Icon * missed some PropsWithChildren in Icon * remove PropsWithChildren from Logo * rm disabled from menu story * add back focus-visible to menu * missed one * remove PropsWithChildren from passeordInput and pipepline * tooltip changeset * tooltip changeset again * changeset for tools/build * number input changeset * test that first menu item is focused * menu, return single value instead of object * update polymorphic error comment * poly and guideCcue comments * guideCue comments * transition types updates * var for index * tooltip tests * updates submenu types, builds in react17/18 * React18 select internal props (#1927) * update select to accept internal props * fix * update changeset * updates changesets * react transition group changeset * code changeset * combobox changeset * icon changeset * lib changetset * update lib changeset * select changeset * testing-lib changeset * tooltip changeset * storybook tools changeset * update storybook changeset * fix lint * fix checks? * add internal prop to skipProps * testing * test changesets * update changesets * remove number-input CustomSelectMenuButton * update __INTERNAL__menuButtonSlotProps__ type * add focusTrapOptions type * revert menu changes * fix TS error * remoe table todo * fix validate errors * fix syntax * remove disabled from headerRow story * remove table README changeset
1 parent 8e06bb2 commit 4fcf2e9

File tree

117 files changed

+2918
-5522
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

117 files changed

+2918
-5522
lines changed

‎.changeset/angry-rice-reply.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/form-footer': patch
3+
---
4+
5+
Updates `PrimaryButton` type from `React.ReactChild` to `React.ReactElement`.

‎.changeset/beige-books-fly.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/testing-lib': patch
3+
---
4+
5+
Fixes `isPromiseLike` TS errors

‎.changeset/cold-planes-change.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/portal': major
3+
---
4+
5+
Modified the ReactDOM peerDependency to ensure compatibility with either version 17 or 18.

‎.changeset/cuddly-donkeys-sit.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/icon': patch
3+
---
4+
5+
Updates internal function, `isComponentGlyph`

‎.changeset/curvy-cheetahs-tap.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/lib': patch
3+
---
4+
5+
Updates helper function, `isComponentType` and updates `ExtendedComponentProps` type.

‎.changeset/cyan-squids-kick.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@lg-tools/build': patch
3+
---
4+
5+
adds `@babel/core` as a peerDependency.

‎.changeset/dull-meals-press.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/segmented-control': patch
3+
---
4+
5+
Refactor internal function `childrenIdList`.

‎.changeset/eleven-trees-deny.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/combobox': patch
3+
---
4+
5+
Type assert children as `Array<React.ReactNode>` inside the internal function `renderedMenuContents` and add explicit return type to internal function `renderCombobox`.

‎.changeset/forty-crews-promise.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@leafygreen-ui/guide-cue': major
3+
---
4+
5+
Downgrades `focus-trap-react` package to `^9.0.2` so that tests still pass without requiring the use of the `fallbackFocus` option on the `<FocusTrap>` component.
6+
7+
Refactors multi-step guideCue so that the tooltip no longer uses a portal, as React 18 displays the tooltip in the wrong position when the viewport changes.

‎.changeset/friendly-planets-tan.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@leafygreen-ui/tooltip': patch
3+
---
4+
5+
Adds the `setOpen()` state update inside `onMouseEnter` inside the [flushSync](https://react.dev/reference/react-dom/flushSync) callback to prevent batch updates in React 18. This addresses an issue where the tooltip would occasionally appear without a transition, particularly when hovering. This should have no impact on behavior in React 17.
6+
7+
Adds an additional check, `isValidElement(trigger)` when checking if the trigger is a LeafyGreenUI Icon or Glyph component.

0 commit comments

Comments
 (0)