Skip to content

Commit eb50ba6

Browse files
Dependency validation [LG-3501 LG-3488] (#1922)
* mv meow, xml2json, svgr to devDependencies * Update validate script to ignore scripts * Update validate pkg to ignore built stories * Adds changesets * typo * Update package.json --------- Co-authored-by: Brooke Scarlett Yalof <[email protected]>
1 parent 433e20f commit eb50ba6

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

.changeset/lucky-dingos-draw.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@lg-tools/validate': patch
3+
---
4+
5+
Ignores dependencies imported from a `/scripts` directory, or `*.stories.js` file.

.changeset/purple-moose-suffer.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@leafygreen-ui/icon': patch
3+
---
4+
5+
Moves some `dependencies` to devDependencies (`@svgr/core`, `@types/meow`, `@types/xml2json`, `meow`)

packages/icon/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@
2424
},
2525
"devDependencies": {
2626
"@leafygreen-ui/palette": "^4.0.7",
27+
"@leafygreen-ui/lib": "^11.0.0",
28+
"@svgr/core": "^5.3.1",
29+
"@types/meow": "^6.0.0",
2730
"@types/xml2json": "^0.11.0",
28-
"xml2json": "^0.12.0",
29-
"@leafygreen-ui/lib": "^11.0.0"
31+
"meow": "^6.1.0",
32+
"xml2json": "^0.12.0"
3033
},
3134
"dependencies": {
3235
"@leafygreen-ui/emotion": "^4.0.7",
33-
"@svgr/core": "^5.3.1",
34-
"@types/meow": "^6.0.0",
35-
"lodash": "^4.17.21",
36-
"meow": "^6.1.0"
36+
"lodash": "^4.17.21"
3737
},
3838
"gitHead": "dd71a2d404218ccec2e657df9c0263dc1c15b9e0",
3939
"homepage": "https://github.com/mongodb/leafygreen-ui/tree/main/packages/icon",

tools/validate/src/dependencies/config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ export interface DependencyIssues {
2020

2121
// We won't check dependencies imported by files matching these patterns
2222
export const ignoreFilePatterns: Array<RegExp> = [
23+
/.*scripts\/.*/,
24+
/.*.stories.js/,
2325
/.*.spec.tsx?/,
2426
/.*.?stor(y|ies).(t|j)sx?/,
2527
/.*.stories.tsx?/,

0 commit comments

Comments
 (0)