[LG-5760] chore: FormFooter Sticky Styling #3344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 42ddd29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +94 B (+0.01%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
adamrasheed
requested review from
TheSonOfThomp,
Copilot,
stephl3 and
tsck
and removed request for
a team
Copilot finished reviewing on behalf of
adamrasheed
November 24, 2025 22:31
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the FormFooter component's internal DOM structure to properly support sticky positioning by separating the outer footer container from the inner content container. This separation allows the overflow shadow utility to be correctly applied to the inner container while maintaining the proper background styling on the outer element, preventing visual issues when the footer uses position: sticky.
Key Changes
- Introduced a new inner container div with
getInnerContainerStyles()that applies the overflow shadow and inherits the background from the outer footer - Moved layout styles (min-height, padding, flex properties) from the outer footer to the inner container
- Updated the Storybook stories to use named imports and added a new
StickyFooterstory demonstrating the sticky positioning use case
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/form-footer/src/FormFooter.tsx |
Added new inner container div between footer and content elements; removed unused cx import; restructured DOM hierarchy to support sticky positioning |
packages/form-footer/src/FormFooter.styles.ts |
Split styles into three layers: outer footer (background, theme), inner container (layout, overflow shadow), and content (flex layout); added getInnerContainerStyles() and getContentStyles() helper functions |
packages/form-footer/src/FormFooter.stories.tsx |
Changed import from default to named export; added new StickyFooter story with sticky positioning example |
tools/install/src/ALL_PACKAGES.ts |
Added two @lg-chat packages to the package list (appears to be unrelated to FormFooter changes) |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| const innerContainerBaseStyle = css` | ||
| min-height: 92px; | ||
| width: 100%; | ||
| padding: 26px 24px; |
Collaborator
There was a problem hiding this comment.
Same here, can we use spacing tokens?
Collaborator
There was a problem hiding this comment.
(Also why 26px? I know that was there previously, but I don't remember why)
Collaborator
Author
There was a problem hiding this comment.
No idea, and I also tried changing from 26px -> 24px with no visual regression, so I'll change it to 24px all around for consistency
Collaborator
Author
There was a problem hiding this comment.
Recapping out slack convo. I confirmed with design it should be 24px all around
Collaborator
TheSonOfThomp
left a comment
TheSonOfThomp
left a comment
There was a problem hiding this comment.
Just missing a changeset
stephl3
reviewed
Nov 25, 2025
| /> | ||
| ); | ||
|
|
||
| const StickyTemplate: StoryType<typeof FormFooter> = ({ |
Collaborator
There was a problem hiding this comment.
If this is intended to be a chromatic snapshot, it could be made more realistic by setting overflow: hidden; on the scrolling div and making this a play test that scrolls to a fixed point before taking the snapshot. There are a couple examples of this in the Drawer stories if you search for a ScrollableAndPadded story
Collaborator
There was a problem hiding this comment.
I don't know if we necessarily need to test that the sticky behavior works on scroll, and just leave it with a test confirming that adding position: sticky; doesn't break it
stephl3
reviewed
Nov 26, 2025
Contributor
|
Coverage after merging ar/LG-5760-shadow into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR refactors the
FormFootercomponent's internal structure to properly support sticky positioning (or prevent the overflow shadow from breaking based on additional styles added throughclassName). The changes separate the outer footer container from the inner content container, allowing the overflow shadow to be applied correctly when the footer is positioned as sticky. Previously, the shadow and background styles were applied to the same element, which caused visual issues in sticky contexts.🎟️ Jira ticket: LG-5760
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
FormFooterStorybook stories