MONGOCRYPT-783 address C99 standard conformance warnings (#973)

* Address -Wnewline-eof warnings
* Address -Wpedantic warnings due to __FUNCTION__
* Address -Wpedantic warnings due to implicit object->function pointer conversion
* Address -Wgnu-zero-variadic-macro-arguments warnings
* Address -Wpedantic warnings due to stray semicolons
* Remove -Wvariadic-macro-arguments-omitted from ENABLE_MORE_WARNINGS_AS_ERRORS

Author: eramongodb

CMakeLists.txt

@@ -712,4 +712,3 @@ install (
    COMPONENT
       Devel
 )
-

kms-message/src/hexlify.h

@@ -21,4 +21,4 @@ char *
 hexlify (const uint8_t *buf, size_t len);
 
 int
-unhexlify (const char *in, size_t len);
+unhexlify (const char *in, size_t len);

kms-message/src/kms_azure_request.c

@@ -216,4 +216,4 @@ kms_azure_request_unwrapkey_new (const char *host,
                                ciphertext,
                                ciphertext_len,
                                opt);
-}
+}

kms-message/src/kms_gcp_request.c

@@ -283,4 +283,4 @@ kms_gcp_request_decrypt_new (const char *host,
                                    ciphertext,
                                    ciphertext_len,
                                    opt);
-}
+}

kms-message/src/kms_request_opt.c

@@ -85,4 +85,4 @@ kms_request_opt_set_crypto_hook_sign_rsaes_pkcs1_v1_5 (
 {
    opt->crypto.sign_rsaes_pkcs1_v1_5 = sign_rsaes_pkcs1_v1_5;
    opt->crypto.sign_ctx = sign_ctx;
-}
+}

kms-message/test/test_kms_assert.h

@@ -44,7 +44,7 @@
 #define TEST_ERROR(...)                                                \
    do {                                                                \
       TEST_STDERR_PRINTF (                                             \
-         "test error %s:%d %s(): ", __FILE__, __LINE__, __FUNCTION__); \
+         "test error %s:%d %s(): ", __FILE__, __LINE__, __func__); \
       TEST_STDERR_PRINTF (__VA_ARGS__);                                \
       TEST_STDERR_PRINTF ("\n");                                       \
       abort ();                                                        \
@@ -161,4 +161,4 @@
       ASSERT_CONTAINS (_error_str, expect_substring);              \
    } while (0)
 
-#endif /* TEST_KMS_ASSERT_H */
+#endif /* TEST_KMS_ASSERT_H */

kms-message/test/test_kms_azure_online.c

@@ -257,4 +257,4 @@ main (int argc, char **argv)
    kms_message_init ();
    test_azure_wrapkey ();
    return 0;
-}
+}

kms-message/test/test_kms_gcp_online.c

@@ -247,4 +247,4 @@ main (int argc, char **argv)
    kms_message_init ();
    test_gcp ();
    return 0;
-}
+}

kms-message/test/test_kms_online_util.c

@@ -117,4 +117,4 @@ send_kms_request (kms_request_t *req, const char *host)
    kms_response_parser_destroy (response_parser);
    mongoc_stream_destroy (tls_stream);
    return response;
-}
+}

kms-message/test/test_kms_online_util.h

@@ -32,4 +32,4 @@ connect_with_tls (const char *host,
 kms_response_t *
 send_kms_request (kms_request_t *req, const char *host);
 
-#endif /* TEST_KMS_ONLINE_UTIL_H */
+#endif /* TEST_KMS_ONLINE_UTIL_H */