CDRIVER-2772 default build type to RelWithDebInfo

Author: ajdavis

.evergreen/compile-unix.sh

@@ -87,7 +87,7 @@ if [ ! -z "$SNAPPY" ]; then
 fi
 
 DEBUG_FLAGS="${DEBUG_AND_RELEASE_FLAGS} -DCMAKE_BUILD_TYPE=Debug"
-RELEASE_FLAGS="${DEBUG_AND_RELEASE_FLAGS} -DCMAKE_BUILD_TYPE=Release"
+RELEASE_FLAGS="${DEBUG_AND_RELEASE_FLAGS} -DCMAKE_BUILD_TYPE=RelWithDebInfo"
 
 DIR=$(dirname $0)
 . $DIR/find-cmake.sh

.evergreen/compile-windows.sh

@@ -112,15 +112,14 @@ case "$CC" in
 esac
 
 if [ "$RELEASE" ]; then
-   CONFIGURE_FLAGS="$CONFIGURE_FLAGS -DCMAKE_BUILD_TYPE=Release"
-   BUILD_FLAGS="$BUILD_FLAGS /p:Configuration=Release"
-   TEST_PATH="./src/libmongoc/Release/test-libmongoc.exe"
-   export PATH=$PATH:`pwd`/tests:`pwd`/Release:`pwd`/src/libbson/Release:`pwd`/src/libmongoc/Release
+   BUILD_FLAGS="$BUILD_FLAGS /p:Configuration=RelWithDebInfo"
+   TEST_PATH="./src/libmongoc/RelWithDebInfo/test-libmongoc.exe"
+   export PATH=$PATH:`pwd`/src/libbson/RelWithDebInfo:`pwd`/src/libmongoc/RelWithDebInfo
 else
-   CONFIGURE_FLAGS="$CONFIGURE_FLAGS -DCMAKE_BUILD_TYPE=Debug"
+   CONFIGURE_FLAGS="$CONFIGURE_FLAGS"
    BUILD_FLAGS="$BUILD_FLAGS /p:Configuration=Debug"
    TEST_PATH="./src/libmongoc/Debug/test-libmongoc.exe"
-   export PATH=$PATH:`pwd`/tests:`pwd`/Debug:`pwd`/src/libbson/Debug:`pwd`/src/libmongoc/Debug
+   export PATH=$PATH:`pwd`/src/libbson/Debug:`pwd`/src/libmongoc/Debug
 fi
 
 "$CMAKE" -G "$CC" "-DCMAKE_PREFIX_PATH=${INSTALL_DIR}/lib/cmake" $CONFIGURE_FLAGS

CMakeLists.txt

@@ -53,6 +53,13 @@ set (ENABLE_ICU AUTO CACHE STRING "Enable ICU support, necessary to use non-ASCI
 
 project (mongo-c-driver C)
 
+if (NOT CMAKE_BUILD_TYPE)
+   set (CMAKE_BUILD_TYPE "RelWithDebInfo")
+   message (
+      STATUS "No CMAKE_BUILD_TYPE selected, defaulting to ${CMAKE_BUILD_TYPE}"
+   )
+endif ()
+
 set (CMAKE_MODULE_PATH
    ${CMAKE_MODULE_PATH}
    ${PROJECT_SOURCE_DIR}/build/cmake

src/libmongoc/doc/installing.rst

@@ -235,7 +235,7 @@ Building on Windows with Visual Studio
 
 Building on Windows requires Windows Vista or newer and Visual Studio 2010 or newer. Additionally, ``cmake`` is required to generate Visual Studio project files.
 
-Let's start by generating Visual Studio project files. The following assumes we are compiling for 64-bit Windows using Visual Studio 2015 Express, which can be freely downloaded from Microsoft. We will be utilizing ``cmake``'s out-of-source build feature to keep build artifacts separate from source files. The default build type is ``Debug``, so a release build is specified as you see below.
+Let's start by generating Visual Studio project files. The following assumes we are compiling for 64-bit Windows using Visual Studio 2015 Express, which can be freely downloaded from Microsoft. We will be utilizing ``cmake``'s out-of-source build feature to keep build artifacts separate from source files.
 
 .. parsed-literal::
 
@@ -249,13 +249,13 @@ Let's start by generating Visual Studio project files. The following assumes we
 
 (Run ``cmake -LH ..`` for a list of other options.)
 
-Now that we have project files generated, we can either open the project in Visual Studio or compile from the command line. Let's build using the command line program ``msbuild.exe``
+Now that we have project files generated, we can either open the project in Visual Studio or compile from the command line. Let's build using the command line program ``msbuild.exe``:
 
 .. code-block:: none
 
-  msbuild.exe ALL_BUILD.vcxproj
+  msbuild.exe /p:Configuration=RelWithDebInfo ALL_BUILD.vcxproj
 
-Now that libmongoc and libbson are compiled, let's install them using msbuild. It will be installed to the path specified by ``CMAKE_INSTALL_PREFIX``.
+Visual Studio's default build type is ``Debug``, but we recommend a release build with debug info for production use. Now that libmongoc and libbson are compiled, let's install them using msbuild. It will be installed to the path specified by ``CMAKE_INSTALL_PREFIX``.
 
 .. code-block:: none