Reduce Warnings - address -Wunused-parameter warnings (#1934)

Author: eramongodb

src/common/src/mlib/cmp.h

@@ -64,6 +64,7 @@ mlib_always_inline static enum mlib_cmp_result (mlib_cmp) (struct mlib_upsized_i
                                                            struct mlib_upsized_integer y,
                                                            int always_zero) mlib_noexcept
 {
+   (void) always_zero;
 #if mlib_is_optimized_build() && !mlib_is_msvc() && \
    !(defined(MLIB_DISABLE_INLINING_ASSERTIONS) && MLIB_DISABLE_INLINING_ASSERTIONS)
    if (always_zero != 0) {

src/libbson/examples/extended-json.c

@@ -20,7 +20,7 @@
 #include <stdio.h>
 
 int
-main (int argc, char *argv[])
+main (void)
 {
    {
       // bson_as_canonical_extended_json ... begin

src/libmongoc/examples/example-structured-log.c

@@ -11,6 +11,8 @@ static pthread_mutex_t handler_mutex;
 static void
 example_handler (const mongoc_structured_log_entry_t *entry, void *user_data)
 {
+   (void) user_data;
+
    mongoc_structured_log_component_t component = mongoc_structured_log_entry_get_component (entry);
    mongoc_structured_log_level_t level = mongoc_structured_log_entry_get_level (entry);
    const char *message_string = mongoc_structured_log_entry_get_message_string (entry);

src/libmongoc/tests/test-mongoc-change-stream.c

@@ -2151,6 +2151,8 @@ test_events_succeeded_cb (const mongoc_apm_command_succeeded_t *e)
 static void
 test_change_stream_batchSize0 (void *test_ctx)
 {
+   BSON_UNUSED (test_ctx);
+
    bson_error_t error;
 
    // Create a change stream. Capture a resume token. Insert documents to create future events.

src/libmongoc/tests/test-mongoc-client-side-encryption.c

@@ -6356,6 +6356,8 @@ _test_retry_with_masterkey (const char *provider, bson_t *masterkey)
 static void
 test_kms_retry (void *unused)
 {
+   BSON_UNUSED (unused);
+
    bson_t *aws_masterkey = tmp_bson (BSON_STR ({"region" : "r", "key" : "k", "endpoint" : "127.0.0.1:9003"}));
    bson_t *azure_masterkey = tmp_bson (BSON_STR ({"keyVaultEndpoint" : "127.0.0.1:9003", "keyName" : "foo"}));
    bson_t *gcp_masterkey = tmp_bson (BSON_STR (

src/libmongoc/tests/test-mongoc-counters.c

@@ -1474,6 +1474,7 @@ test_counters_auth_pooled_op_msg (void *context)
 void
 test_counters_install (TestSuite *suite)
 {
+   BSON_UNUSED (suite);
 #ifdef MONGOC_ENABLE_SHM_COUNTERS
    TestSuite_AddFull (suite,
                       "/counters/op_msg",

src/libmongoc/tests/unified/runner.c

@@ -1443,7 +1443,7 @@ check_failure_is_redacted (const bson_iter_t *failure_iter, bson_error_t *error)
 }
 
 static bool
-check_failure_is_detailed (const bson_iter_t *failure_iter, bson_error_t *error)
+check_failure_is_detailed (const bson_iter_t *failure_iter)
 {
    if (BSON_ITER_HOLDS_UTF8 (failure_iter)) {
       // Strings are fine, that's enough proof that the failure was not redacted
@@ -1467,7 +1467,7 @@ check_failure_is_detailed (const bson_iter_t *failure_iter, bson_error_t *error)
 }
 
 static bool
-test_check_log_message (test_t *test, bson_t *expected, log_message_t *actual, bson_error_t *error)
+test_check_log_message (bson_t *expected, log_message_t *actual, bson_error_t *error)
 {
    bool ret = false;
 
@@ -1524,7 +1524,7 @@ test_check_log_message (test_t *test, bson_t *expected, log_message_t *actual, b
             goto done;
          }
       } else {
-         if (!check_failure_is_detailed (&failure_iter, error)) {
+         if (!check_failure_is_detailed (&failure_iter)) {
             test_diagnostics_error_info ("actual log message: %s", tmp_json (actual->message));
             test_set_error (error, "expected a complete un-redacted 'failure'");
             goto done;
@@ -1550,18 +1550,15 @@ test_check_log_message (test_t *test, bson_t *expected, log_message_t *actual, b
 }
 
 static bool
-test_log_message_should_be_ignored (test_t *test,
-                                    log_message_t *message,
-                                    bson_t *optional_ignore_list,
-                                    bson_error_t *error)
+test_log_message_should_be_ignored (log_message_t *message, bson_t *optional_ignore_list, bson_error_t *error)
 {
    if (optional_ignore_list) {
       bson_iter_t iter;
       BSON_FOREACH (optional_ignore_list, iter)
       {
          bson_t expected;
          bson_iter_bson (&iter, &expected);
-         bool is_match = test_check_log_message (test, &expected, message, error);
+         bool is_match = test_check_log_message (&expected, message, error);
          bson_destroy (&expected);
          if (is_match) {
             return true;
@@ -1615,8 +1612,7 @@ test_check_expected_log_messages_for_client (test_t *test,
       bson_iter_init (&expected_message_iter, expected_messages) && bson_iter_next (&expected_message_iter);
 
    while (actual_message_iter || expected_message_iter_ok) {
-      if (actual_message_iter &&
-          test_log_message_should_be_ignored (test, actual_message_iter, ignore_messages, error)) {
+      if (actual_message_iter && test_log_message_should_be_ignored (actual_message_iter, ignore_messages, error)) {
          MONGOC_DEBUG ("log message ignored, %s", tmp_json (actual_message_iter->message));
          actual_message_iter = actual_message_iter->next;
          continue;
@@ -1640,7 +1636,7 @@ test_check_expected_log_messages_for_client (test_t *test,
       }
       bson_t expected_message;
       bson_iter_bson (&expected_message_iter, &expected_message);
-      bool is_match = test_check_log_message (test, &expected_message, actual_message_iter, error);
+      bool is_match = test_check_log_message (&expected_message, actual_message_iter, error);
       MONGOC_DEBUG ("log message check %s %s, expected: %s, actual: %s",
                     is_match ? "MATCHED" : "FAILED",
                     error && !is_match ? error->message : "",

src/tools/mongoc-stat.c

@@ -220,7 +220,7 @@ main (int argc, char *argv[])
 #include <stdio.h>
 
 int
-main (int argc, char *argv[])
+main (void)
 {
    fprintf (stderr, "mongoc-stat is not supported on your platform.\n");
    return EXIT_FAILURE;