CDRIVER-647: Fix invalid read in tracing on read failure

bjori · bjori · commit 21c0ea4e0205 · 2015-09-25T09:04:24.000-07:00
diff --git a/src/mongoc/mongoc-stream.c b/src/mongoc/mongoc-stream.c
@@ -232,7 +232,9 @@ mongoc_stream_readv (mongoc_stream_t *stream,
    BSON_ASSERT (stream->readv);
 
    ret = stream->readv (stream, iov, iovcnt, min_bytes, timeout_msec);
-   DUMP_IOVEC (readv, iov, iovcnt);
+   if (ret >= 0) {
+      DUMP_IOVEC (readv, iov, iovcnt);
+   }
 
    RETURN (ret);
 }

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,9 @@ mongoc_stream_readv (mongoc_stream_t *stream,`
`232`	`232`	`BSON_ASSERT (stream->readv);`
`233`	`233`
`234`	`234`	`ret = stream->readv (stream, iov, iovcnt, min_bytes, timeout_msec);`
`235`		`- DUMP_IOVEC (readv, iov, iovcnt);`
	`235`	`+ if (ret >= 0) {`
	`236`	`+ DUMP_IOVEC (readv, iov, iovcnt);`
	`237`	`+ }`
`236`	`238`
`237`	`239`	`RETURN (ret);`
`238`	`240`	`}`