CDRIVER-3725 fix uninitialized read

kevinAlbs · kevinAlbs · commit 25b8729e8b1d · 2020-07-11T12:13:07.000-04:00
diff --git a/src/libmongoc/src/mongoc/mongoc-cluster-sspi.c b/src/libmongoc/src/mongoc/mongoc-cluster-sspi.c
@@ -266,8 +266,9 @@ _mongoc_cluster_auth_node_sspi (mongoc_cluster_t *cluster,
 
       tmpstr = bson_iter_utf8 (&iter, &buflen);
       bson_free (buf);
-      buf = bson_malloc (sizeof (SEC_CHAR) * buflen);
+      buf = bson_malloc (sizeof (SEC_CHAR) * (buflen + 1));
       memcpy (buf, tmpstr, buflen);
+      buf[buflen] = (SEC_CHAR) 0;
 
       bson_destroy (&reply);
    }

Original file line number	Diff line number	Diff line change
`@@ -266,8 +266,9 @@ _mongoc_cluster_auth_node_sspi (mongoc_cluster_t *cluster,`
`266`	`266`
`267`	`267`	`tmpstr = bson_iter_utf8 (&iter, &buflen);`
`268`	`268`	`bson_free (buf);`
`269`		`- buf = bson_malloc (sizeof (SEC_CHAR) * buflen);`
	`269`	`+ buf = bson_malloc (sizeof (SEC_CHAR) * (buflen + 1));`
`270`	`270`	`memcpy (buf, tmpstr, buflen);`
	`271`	`+ buf[buflen] = (SEC_CHAR) 0;`
`271`	`272`
`272`	`273`	`bson_destroy (&reply);`
`273`	`274`	`}`