CDRIVER-2604 remove mongoc_cursor_is_alive (#1916)

Author: kevinAlbs

NEWS

@@ -17,6 +17,7 @@ Unreleased (2.0.0)
 * `MONGOC_QUERY_SLAVE_OK` is removed. Use the equivalent `MONGOC_QUERY_SECONDARY_OK` instead.
 * `MONGOC_URI_SLAVEOK` is removed. It was unused.
 * `mongoc_collection_save` is removed. Use `mongoc_collection_insert_one` or `mongoc_collection_replace_one` instead.
+* `mongoc_cursor_is_alive` is removed. Use the equivalent `mongoc_cursor_more` instead.
 * `mongoc_collection_delete` is removed. Use `mongoc_collection_delete_one` or `mongoc_collection_delete_many` instead.
 * `mongoc_delete_flags_t` and `mongoc_reply_flags_t` are removed.
 

src/libmongoc/doc/mongoc_cursor_is_alive.rst

@@ -57,7 +57,6 @@ Example
     mongoc_cursor_get_id
     mongoc_cursor_get_limit
     mongoc_cursor_get_max_await_time_ms
-    mongoc_cursor_is_alive
     mongoc_cursor_more
     mongoc_cursor_new_from_command_reply
     mongoc_cursor_new_from_command_reply_with_opts

src/libmongoc/doc/mongoc_cursor_t.rst

@@ -1421,23 +1421,6 @@ mongoc_cursor_clone (const mongoc_cursor_t *cursor)
 }
 
 
-/*
- *--------------------------------------------------------------------------
- *
- * mongoc_cursor_is_alive --
- *
- *       Deprecated for mongoc_cursor_more.
- *
- *--------------------------------------------------------------------------
- */
-
-bool
-mongoc_cursor_is_alive (const mongoc_cursor_t *cursor) /* IN */
-{
-   return mongoc_cursor_more ((mongoc_cursor_t *) cursor);
-}
-
-
 const bson_t *
 mongoc_cursor_current (const mongoc_cursor_t *cursor) /* IN */
 {

src/libmongoc/src/mongoc/mongoc-cursor.c

@@ -55,8 +55,6 @@ mongoc_cursor_error_document (mongoc_cursor_t *cursor, bson_error_t *error, cons
 MONGOC_EXPORT (void)
 mongoc_cursor_get_host (mongoc_cursor_t *cursor, mongoc_host_list_t *host);
 
-BSON_DEPRECATED_FOR (mongoc_cursor_more) MONGOC_EXPORT (bool) mongoc_cursor_is_alive (const mongoc_cursor_t *cursor);
-
 MONGOC_EXPORT (const bson_t *)
 mongoc_cursor_current (const mongoc_cursor_t *cursor);
 

src/libmongoc/src/mongoc/mongoc-cursor.h

@@ -2212,8 +2212,7 @@ test_error_document_getmore (void)
 }
 
 /* test that an error during constructing a find cursor causes the cursor to
- * be marked as failed, so mongoc_cursor_is_alive and mongoc_cursor_more return
- * false */
+ * be marked as failed, mongoc_cursor_more returns false */
 static void
 test_find_error_is_alive (void)
 {
@@ -2229,7 +2228,6 @@ test_find_error_is_alive (void)
    BSON_ASSERT (mongoc_cursor_error (cursor, &err));
    ASSERT_ERROR_CONTAINS (
       err, MONGOC_ERROR_CURSOR, MONGOC_ERROR_CURSOR_INVALID_CURSOR, "Cannot mix $query with non-dollar field");
-   BSON_ASSERT (!mongoc_cursor_is_alive (cursor));
    BSON_ASSERT (!mongoc_cursor_more (cursor));
    BSON_ASSERT (!mongoc_cursor_next (cursor, &bson));
    mongoc_cursor_destroy (cursor);