CDRIVER-3091 fix copyrights and OriginalFilename (#1457)

* use `*OUTPUT_BASENAME ` to define `OriginalFilename`

* use project inception date as copyright year

* quote macros in .rc file, not CMake

The MinGW resource compiler (windres) does not appear to keep quotes on arguments passed to the preprocessor.

* use `configure_file` to simplify

* use `API_VERSION` macros in place of `1.0` literals

* guard config of `.rc` files in `if(WIN32)`

For consistency with C++ driver.

* set `InternalName` to `OriginalFilename` without extension

Author: kevinAlbs

src/libbson/CMakeLists.txt

@@ -228,7 +228,12 @@ if(ENABLE_STATIC)
 endif()
 
 if(ENABLE_SHARED)
-   add_library(bson_shared SHARED $<$<PLATFORM_ID:Windows>:libbson.rc>)
+   add_library(bson_shared SHARED)
+   if(WIN32)
+      # Add resource-definition script for Windows shared library (.dll).
+      configure_file(libbson.rc.in libbson.rc)
+      target_sources(bson_shared PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/libbson.rc)
+   endif()
    target_link_libraries(bson_shared PRIVATE $<BUILD_INTERFACE:bson_obj_pic>)
    list(APPEND bson_libs bson_shared)
 endif()

src/libbson/libbson.rc renamed to src/libbson/libbson.rc.in

@@ -5,6 +5,9 @@
 #include <bson/bson-version.h> // Defines BSON_MAJOR_VERSION and other version macros.
 #undef BSON_COMPILATION
 
+#define BSON_OUTPUT_BASENAME "@BSON_OUTPUT_BASENAME@"
+#define BSON_API_VERSION "@BSON_API_VERSION@"
+
 VS_VERSION_INFO VERSIONINFO
  FILEVERSION BSON_MAJOR_VERSION,BSON_MINOR_VERSION,BSON_MICRO_VERSION,0
  PRODUCTVERSION BSON_MAJOR_VERSION,BSON_MINOR_VERSION,BSON_MICRO_VERSION,0
@@ -28,11 +31,11 @@ BEGIN
             VALUE "CompanyName", "MongoDB, Inc"
             VALUE "FileDescription", "A BSON Library for C"
             VALUE "FileVersion", BSON_VERSION_S
-            VALUE "InternalName", "bson-1.0"
-            VALUE "OriginalFilename", "bson-1.0.dll"
+            VALUE "InternalName", BSON_OUTPUT_BASENAME "-" BSON_API_VERSION
+            VALUE "OriginalFilename", BSON_OUTPUT_BASENAME "-" BSON_API_VERSION ".dll"
             VALUE "ProductName", "MongoDB C Driver"
             VALUE "ProductVersion", BSON_VERSION_S
-            VALUE "LegalCopyright", "Copyright (C) 2023-present MongoDB, Inc."
+            VALUE "LegalCopyright", "Copyright (C) 2013-present MongoDB, Inc."
         END
     END
     BLOCK "VarFileInfo"

src/libmongoc/CMakeLists.txt

@@ -812,7 +812,12 @@ if (MONGOC_ENABLE_STATIC_BUILD)
    set_target_properties (mcd_rpc PROPERTIES OUTPUT_NAME "mcd-rpc")
 endif ()
 
-add_library (mongoc_shared SHARED ${SOURCES} ${HEADERS} ${HEADERS_FORWARDING} $<$<PLATFORM_ID:Windows>:libmongoc.rc>)
+add_library (mongoc_shared SHARED ${SOURCES} ${HEADERS} ${HEADERS_FORWARDING})
+if(WIN32)
+   # Add resource-definition script for Windows shared library (.dll).
+   configure_file(libmongoc.rc.in libmongoc.rc)
+   target_sources(mongoc_shared PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/libmongoc.rc)
+endif()
 set_target_properties (mongoc_shared PROPERTIES CMAKE_CXX_VISIBILITY_PRESET hidden)
 target_link_libraries (mongoc_shared PRIVATE ${LIBRARIES} PUBLIC ${BSON_LIBRARIES} mongo::detail::c_dependencies)
 target_include_directories (mongoc_shared PRIVATE ${ZLIB_INCLUDE_DIRS})

src/libmongoc/libmongoc.rc renamed to src/libmongoc/libmongoc.rc.in

@@ -3,6 +3,9 @@
 #include <winver.h> // Defines VS_VERSION_INFO
 #include <mongoc/mongoc-version.h> // Defines MONGOC_MAJOR_VERSION and other version macros.
 
+#define MONGOC_OUTPUT_BASENAME "@MONGOC_OUTPUT_BASENAME@"
+#define MONGOC_API_VERSION "@MONGOC_API_VERSION@"
+
 VS_VERSION_INFO VERSIONINFO
  FILEVERSION MONGOC_MAJOR_VERSION,MONGOC_MINOR_VERSION,MONGOC_MICRO_VERSION,0
  PRODUCTVERSION MONGOC_MAJOR_VERSION,MONGOC_MINOR_VERSION,MONGOC_MICRO_VERSION,0
@@ -26,11 +29,11 @@ BEGIN
             VALUE "CompanyName", "MongoDB, Inc"
             VALUE "FileDescription", "MongoDB Client Library for C"
             VALUE "FileVersion", MONGOC_VERSION_S
-            VALUE "InternalName", "mongoc-1.0"
-            VALUE "OriginalFilename", "mongoc-1.0.dll"
+            VALUE "InternalName", MONGOC_OUTPUT_BASENAME "-" MONGOC_API_VERSION
+            VALUE "OriginalFilename", MONGOC_OUTPUT_BASENAME "-" MONGOC_API_VERSION ".dll"
             VALUE "ProductName", "MongoDB C Driver"
             VALUE "ProductVersion", MONGOC_VERSION_S
-            VALUE "LegalCopyright", "Copyright (C) 2023-present MongoDB, Inc."
+            VALUE "LegalCopyright", "Copyright (C) 2013-present MongoDB, Inc."
         END
     END
     BLOCK "VarFileInfo"