Skip to content

Commit 47da505

Browse files
author
Christian Hergert
committed
buffer: fix references to new buffer init.
1 parent 57308ff commit 47da505

9 files changed

+21
-16
lines changed

src/mongoc/mongoc-buffer-private.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,21 @@ typedef struct _mongoc_buffer_t mongoc_buffer_t;
3232

3333
struct _mongoc_buffer_t
3434
{
35-
uint8_t *data;
35+
uint8_t *data;
3636
size_t datalen;
3737
off_t off;
3838
size_t len;
3939
bson_realloc_func realloc_func;
40+
void *realloc_data;
4041
};
4142

4243

4344
void
4445
_mongoc_buffer_init (mongoc_buffer_t *buffer,
45-
uint8_t *buf,
46+
uint8_t *buf,
4647
size_t buflen,
47-
bson_realloc_func realloc_func)
48+
bson_realloc_func realloc_func,
49+
void *realloc_data)
4850
BSON_GNUC_INTERNAL;
4951

5052
bool

src/mongoc/mongoc-buffer.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ void
5252
_mongoc_buffer_init (mongoc_buffer_t *buffer,
5353
uint8_t *buf,
5454
size_t buflen,
55-
bson_realloc_func realloc_func)
55+
bson_realloc_func realloc_func,
56+
void *realloc_data)
5657
{
5758
bson_return_if_fail (buffer);
5859
bson_return_if_fail (buflen || !buf);
@@ -76,6 +77,7 @@ _mongoc_buffer_init (mongoc_buffer_t *buffer,
7677
buffer->len = 0;
7778
buffer->off = 0;
7879
buffer->realloc_func = realloc_func;
80+
buffer->realloc_data = realloc_data;
7981
}
8082

8183

@@ -91,7 +93,7 @@ _mongoc_buffer_destroy (mongoc_buffer_t *buffer)
9193
bson_return_if_fail(buffer);
9294

9395
if (buffer->data && buffer->realloc_func) {
94-
buffer->realloc_func(buffer->data, 0, NULL);
96+
buffer->realloc_func (buffer->data, 0, buffer->realloc_data);
9597
}
9698

9799
memset(buffer, 0, sizeof *buffer);
@@ -209,8 +211,8 @@ _mongoc_buffer_fill (mongoc_buffer_t *buffer,
209211
bson_return_val_if_fail(stream, false);
210212
bson_return_val_if_fail(min_bytes >= 0, false);
211213

212-
BSON_ASSERT(buffer->data);
213-
BSON_ASSERT(buffer->datalen);
214+
BSON_ASSERT (buffer->data);
215+
BSON_ASSERT (buffer->datalen);
214216

215217
if (min_bytes <= buffer->len) {
216218
RETURN (buffer->len);
@@ -226,7 +228,8 @@ _mongoc_buffer_fill (mongoc_buffer_t *buffer,
226228

227229
if (!SPACE_FOR (buffer, min_bytes)) {
228230
buffer->datalen = bson_next_power_of_two ((uint32_t)(buffer->len + min_bytes));
229-
buffer->data = bson_realloc (buffer->data, buffer->datalen);
231+
buffer->data = buffer->realloc_func (buffer->data, buffer->datalen,
232+
buffer->realloc_data);
230233
}
231234

232235
avail_bytes = buffer->datalen - buffer->len;

src/mongoc/mongoc-client.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,7 @@ _mongoc_client_recv_gle (mongoc_client_t *client,
595595
*gle_doc = NULL;
596596
}
597597

598-
_mongoc_buffer_init (&buffer, NULL, 0, NULL);
598+
_mongoc_buffer_init (&buffer, NULL, 0, NULL, NULL);
599599

600600
if (!_mongoc_cluster_try_recv (&client->cluster, &rpc, &buffer,
601601
hint, error)) {

src/mongoc/mongoc-cluster.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,7 @@ _mongoc_cluster_run_command (mongoc_cluster_t *cluster,
872872
rpc.query.fields = NULL;
873873

874874
_mongoc_array_init (&ar, sizeof (mongoc_iovec_t));
875-
_mongoc_buffer_init (&buffer, NULL, 0, NULL);
875+
_mongoc_buffer_init (&buffer, NULL, 0, NULL, NULL);
876876

877877
_mongoc_rpc_gather(&rpc, &ar);
878878
_mongoc_rpc_swab_to_le(&rpc);

src/mongoc/mongoc-collection.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ _mongoc_collection_new (mongoc_client_t *client,
166166
col->collectionlen = (uint32_t)strlen(col->collection);
167167
col->nslen = (uint32_t)strlen(col->ns);
168168

169-
_mongoc_buffer_init(&col->buffer, NULL, 0, NULL);
169+
_mongoc_buffer_init(&col->buffer, NULL, 0, NULL, NULL);
170170

171171
col->gle = NULL;
172172

src/mongoc/mongoc-cursor.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ _mongoc_cursor_new (mongoc_client_t *client,
271271
bson_init(&cursor->fields);
272272
}
273273

274-
_mongoc_buffer_init(&cursor->buffer, NULL, 0, NULL);
274+
_mongoc_buffer_init(&cursor->buffer, NULL, 0, NULL, NULL);
275275

276276
finish:
277277
mongoc_counter_cursors_active_inc();
@@ -960,7 +960,7 @@ _mongoc_cursor_clone (const mongoc_cursor_t *cursor)
960960

961961
bson_strncpy (_clone->ns, cursor->ns, sizeof _clone->ns);
962962

963-
_mongoc_buffer_init (&_clone->buffer, NULL, 0, NULL);
963+
_mongoc_buffer_init (&_clone->buffer, NULL, 0, NULL, NULL);
964964

965965
mongoc_counter_cursors_active_inc ();
966966

src/mongoc/mongoc-stream-buffered.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ mongoc_stream_buffered_new (mongoc_stream_t *base_stream, /* IN */
338338

339339
stream->base_stream = base_stream;
340340

341-
_mongoc_buffer_init (&stream->buffer, NULL, buffer_size, bson_realloc_ctx);
341+
_mongoc_buffer_init (&stream->buffer, NULL, buffer_size, NULL, NULL);
342342

343343
mongoc_counter_streams_active_inc();
344344

tests/mock-server.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ mock_server_worker (void *data)
215215
server = closure[0];
216216
stream = closure[1];
217217

218-
_mongoc_buffer_init(&buffer, NULL, 0, NULL);
218+
_mongoc_buffer_init(&buffer, NULL, 0, NULL, NULL);
219219

220220
again:
221221
if (_mongoc_buffer_fill (&buffer, stream, 4, -1, &error) == -1) {

tests/test-mongoc-buffer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test_mongoc_buffer_basic (void)
1717
stream = mongoc_stream_file_new_for_path (BINARY_DIR"/reply1.dat", O_RDONLY, 0);
1818
ASSERT(stream);
1919

20-
_mongoc_buffer_init(&buf, data, 1024, bson_realloc_ctx);
20+
_mongoc_buffer_init(&buf, data, 1024, NULL, NULL);
2121

2222
r = _mongoc_buffer_fill(&buf, stream, 537, 0, &error);
2323
ASSERT_CMPINT((int)r, ==, -1);

0 commit comments

Comments
 (0)