leaks in tests

Author: ajdavis

tests/mock_server/mock-rs.c

@@ -134,9 +134,6 @@ mock_rs_with_autoismaster (int32_t max_wire_version,
    rs->n_secondaries = n_secondaries;
    rs->n_arbiters = n_arbiters;
    rs->request_timeout_msec = 10 * 1000;
-   _mongoc_array_init (&rs->secondaries, sizeof (mock_server_t *));
-   _mongoc_array_init (&rs->arbiters, sizeof (mock_server_t *));
-   _mongoc_array_init (&rs->servers, sizeof (mock_server_t *));
    rs->q = q_new ();
    rs->verbose = test_framework_getenv_bool ("MONGOC_TEST_SERVER_VERBOSE");
 
@@ -263,6 +260,7 @@ mock_rs_run (mock_rs_t *rs)
    }
 
    /* add all servers to replica set */
+   _mongoc_array_init (&rs->servers, sizeof(mock_server_t *));
    if (rs->has_primary) {
       _mongoc_array_append_val (&rs->servers, rs->primary);
    }
@@ -504,6 +502,8 @@ mock_rs_receives_command (mock_rs_t *rs,
       return NULL;
    }
 
+   bson_free (ns);
+
    return request;
 }
 

tests/test-bulk.c

@@ -2137,6 +2137,7 @@ test_large_inserts_ordered (void)
 
    bson_destroy (&reply);
    mongoc_bulk_operation_destroy (bulk);
+   mongoc_cursor_destroy (cursor);
    mongoc_collection_destroy (collection);
    bson_destroy (huge_doc);
    mongoc_client_destroy (client);

tests/test-mongoc-client.c

@@ -953,8 +953,8 @@ test_mongoc_client_unix_domain_socket (void *context)
    assert (bson_iter_init_find (&iter, &reply, "ok"));
 
    bson_destroy (&reply);
-
    mongoc_client_destroy (client);
+   bson_free (uri_str);
 }
 
 

tests/test-mongoc-collection-find.c

@@ -141,6 +141,7 @@ _test_collection_find_live (test_collection_find_t *test_data)
    bson_free (drop_cmd);
    mongoc_cursor_destroy (cursor);
    mongoc_collection_destroy (collection);
+   mongoc_database_destroy (database);
    bson_free (collection_name);
    mongoc_client_destroy (client);
 }
@@ -236,6 +237,8 @@ _test_collection_op_query_or_find_command (
                        test_data->filename, test_data->lineno,
                        test_data->funcname, test_data->expected_result));
 
+   request_destroy (request);
+   future_destroy (future);
    mongoc_cursor_destroy (cursor);
    mongoc_collection_destroy (collection);
    mongoc_client_destroy (client);
@@ -282,6 +285,8 @@ _reply_to_op_query (request_t              *request,
 
    mock_server_reply_multi (request, MONGOC_REPLY_NONE, docs,
                             test_data->n_results, 0 /* cursor_id */);
+
+   bson_free (docs);
 }
 
 
@@ -1049,6 +1054,7 @@ _test_tailable_timeout (bool pooled)
    bson_destroy (&reply);
    mongoc_cursor_destroy (cursor);
    mongoc_collection_destroy (collection);
+   mongoc_database_destroy (database);
    bson_free (collection_name);
 
    if (pooled) {

tests/test-mongoc-collection.c

@@ -1329,6 +1329,8 @@ test_count_read_concern (void)
    mock_server_replies_simple (request, "{ 'n' : 42, 'ok' : 1 } ");
    count = future_get_int64_t (future);
    ASSERT_OR_PRINT (count == 42, error);
+   request_destroy (request);
+   future_destroy (future);
 
    /* readConcern: { level: majority } */
    rc = mongoc_read_concern_new ();
@@ -1347,7 +1349,8 @@ test_count_read_concern (void)
    count = future_get_int64_t (future);
    ASSERT_OR_PRINT (count == 43, error);
    mongoc_read_concern_destroy (rc);
-
+   request_destroy (request);
+   future_destroy (future);
 
    /* readConcern: { level: local } */
    rc = mongoc_read_concern_new ();
@@ -1366,6 +1369,8 @@ test_count_read_concern (void)
    count = future_get_int64_t (future);
    ASSERT_OR_PRINT (count == 44, error);
    mongoc_read_concern_destroy (rc);
+   request_destroy (request);
+   future_destroy (future);
 
    /* readConcern: { level: futureCompatible } */
    rc = mongoc_read_concern_new ();
@@ -1384,6 +1389,8 @@ test_count_read_concern (void)
    count = future_get_int64_t (future);
    ASSERT_OR_PRINT (count == 45, error);
    mongoc_read_concern_destroy (rc);
+   request_destroy (request);
+   future_destroy (future);
 
    /* Setting readConcern to NULL should not send readConcern */
    rc = mongoc_read_concern_new ();
@@ -1402,6 +1409,8 @@ test_count_read_concern (void)
    count = future_get_int64_t (future);
    ASSERT_OR_PRINT (count == 46, error);
    mongoc_read_concern_destroy (rc);
+   request_destroy (request);
+   future_destroy (future);
 
    /* Fresh read_concern should not send readConcern */
    rc = mongoc_read_concern_new ();
@@ -1418,8 +1427,10 @@ test_count_read_concern (void)
    mock_server_replies_simple (request, "{ 'n' : 47, 'ok' : 1 } ");
    count = future_get_int64_t (future);
    ASSERT_OR_PRINT (count == 47, error);
-   mongoc_read_concern_destroy (rc);
 
+   mongoc_read_concern_destroy (rc);
+   request_destroy (request);
+   future_destroy (future);
    mongoc_collection_destroy (collection);
    mongoc_client_destroy (client);
    mock_server_destroy (server);
@@ -1708,6 +1719,7 @@ test_aggregate (void)
    ASSERT (!r);
    ASSERT (mongoc_cursor_error (cursor, &error));
    ASSERT (error.code == 16436);
+   mongoc_cursor_destroy (cursor);
 
    for (i = 0; i < 2; i++) {
       if (i % 2 == 0) {
@@ -2721,6 +2733,7 @@ test_find_read_concern (void)
    future_destroy (future);
    request_destroy (request);
    mongoc_cursor_destroy (cursor);
+   mongoc_read_concern_destroy (rc);
 
    /* readConcernLevel = random */
    rc = mongoc_read_concern_new ();
@@ -2753,6 +2766,7 @@ test_find_read_concern (void)
    future_destroy (future);
    request_destroy (request);
    mongoc_cursor_destroy (cursor);
+   mongoc_read_concern_destroy (rc);
 
    /* empty readConcernLevel doesn't send anything */
    rc = mongoc_read_concern_new ();
@@ -2782,6 +2796,7 @@ test_find_read_concern (void)
    future_destroy (future);
    request_destroy (request);
    mongoc_cursor_destroy (cursor);
+   mongoc_read_concern_destroy (rc);
 
    /* readConcernLevel = NULL doesn't send anything */
    rc = mongoc_read_concern_new ();
@@ -2809,10 +2824,11 @@ test_find_read_concern (void)
          "    'ns': 'test.test',"
          "    'firstBatch': [{'_id': 123}]}}");
    ASSERT (future_get_bool (future));
+
    future_destroy (future);
    request_destroy (request);
    mongoc_cursor_destroy (cursor);
-
+   mongoc_read_concern_destroy (rc);
    mongoc_collection_destroy(collection);
    mongoc_client_destroy(client);
    mock_server_destroy (server);
@@ -2919,7 +2935,7 @@ test_aggregate_read_concern (void)
    request_destroy (request);
    future_destroy (future);
 
-
+   mongoc_read_concern_destroy (rc);
    mongoc_collection_destroy (collection);
    mongoc_client_destroy (client);
    mock_server_destroy (server);

tests/test-mongoc-cursor.c

@@ -220,6 +220,11 @@ test_kill_cursor_live (void)
                           MONGOC_ERROR_CURSOR,
                           16,
                           "cursor is invalid");
+
+   mongoc_cursor_destroy (cursor);
+   mongoc_bulk_operation_destroy (bulk);
+   mongoc_collection_destroy (collection);
+   mongoc_client_destroy (client);
 }
 
 

tests/test-mongoc-exhaust.c

@@ -346,6 +346,10 @@ test_cursor_set_max_await_time_ms (void)
    /* once started, cursor ignores set_max_await_time_ms () */
    mongoc_cursor_set_max_await_time_ms (cursor, 42);
    ASSERT_CMPINT (123, ==, mongoc_cursor_get_max_await_time_ms (cursor));
+
+   mongoc_cursor_destroy (cursor);
+   mongoc_collection_destroy (collection);
+   mongoc_client_destroy (client);
 }
 
 typedef enum