Skip to content

Commit 5a108cb

Browse files
committed
CDRIVER-1458 disable /Socket/check_closed on Mac
1 parent 09f2b42 commit 5a108cb

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

tests/test-libmongoc.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1552,6 +1552,17 @@ test_framework_skip_if_windows (void)
15521552
}
15531553

15541554

1555+
int
1556+
test_framework_skip_if_apple (void)
1557+
{
1558+
#ifdef __APPLE__
1559+
return false;
1560+
#else
1561+
return true;
1562+
#endif
1563+
}
1564+
1565+
15551566
/* skip if no Unix domain socket */
15561567
int
15571568
test_framework_skip_if_no_uds (void)

tests/test-libmongoc.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,8 @@ test_framework_skip_if_single (void);
128128
int
129129
test_framework_skip_if_windows (void);
130130
int
131+
test_framework_skip_if_apple (void);
132+
int
131133
test_framework_skip_if_no_uds (void); /* skip if no Unix domain socket */
132134
int
133135
test_framework_skip_if_not_mongos (void);

tests/test-mongoc-socket.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ sendv_test_client (void *data_)
318318

319319

320320
static void
321-
test_mongoc_socket_check_closed (void)
321+
test_mongoc_socket_check_closed (void *ctx)
322322
{
323323
socket_test_data_t data = {0};
324324
mongoc_thread_t threads[2];
@@ -342,6 +342,7 @@ test_mongoc_socket_check_closed (void)
342342
mongoc_cond_destroy (&data.cond);
343343
}
344344

345+
345346
static void
346347
test_mongoc_socket_sendv (void *ctx)
347348
{
@@ -370,8 +371,12 @@ test_mongoc_socket_sendv (void *ctx)
370371
void
371372
test_socket_install (TestSuite *suite)
372373
{
373-
TestSuite_Add (
374-
suite, "/Socket/check_closed", test_mongoc_socket_check_closed);
374+
TestSuite_AddFull (suite,
375+
"/Socket/check_closed",
376+
test_mongoc_socket_check_closed,
377+
NULL,
378+
NULL,
379+
test_framework_skip_if_apple);
375380
TestSuite_AddFull (suite,
376381
"/Socket/sendv",
377382
test_mongoc_socket_sendv,

0 commit comments

Comments
 (0)