Skip to content

Commit 6de38dd

Browse files
committed
CDRIVER-1305 disable timeout tests on all 32-bit Unix
1 parent 3913e40 commit 6de38dd

File tree

1 file changed

+33
-20
lines changed

1 file changed

+33
-20
lines changed

tests/test-mongoc-topology.c

Lines changed: 33 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,6 @@ test_max_wire_version_race_condition (void *ctx)
455455
}
456456

457457

458-
#if !defined(__sun) /* CDRIVER-1305 */
459458
static void
460459
test_cooldown_standalone (void *ctx)
461460
{
@@ -925,7 +924,6 @@ test_multiple_selection_errors (void *context)
925924

926925
mongoc_client_destroy (client);
927926
}
928-
#endif
929927

930928

931929
static void
@@ -946,6 +944,8 @@ test_invalid_server_id (void)
946944
void
947945
test_topology_install (TestSuite *suite)
948946
{
947+
bool windows;
948+
949949
TestSuite_AddLive (suite, "/Topology/client_creation", test_topology_client_creation);
950950
TestSuite_AddLive (suite, "/Topology/client_pool_creation", test_topology_client_pool_creation);
951951
TestSuite_AddFull (suite, "/Topology/server_selection_try_once_option",
@@ -962,25 +962,38 @@ test_topology_install (TestSuite *suite)
962962
test_max_wire_version_race_condition,
963963
NULL, NULL, test_framework_skip_if_no_auth);
964964

965-
#if !defined(__sun) /* CDRIVER-1305 */
966-
TestSuite_AddFull (suite, "/Topology/cooldown/standalone",
967-
test_cooldown_standalone, NULL, NULL, test_framework_skip_if_slow);
968-
TestSuite_AddFull (suite, "/Topology/cooldown/rs",
969-
test_cooldown_rs, NULL, NULL, test_framework_skip_if_slow);
965+
/* CDRIVER-1305: disable tests that hang on 32-bit Unix */
966+
#ifdef _MSC_VER
967+
windows = true;
968+
#else
969+
windows = false;
970970
#endif
971971

972-
#if !defined(__sun) /* CDRIVER-1305 */
973-
TestSuite_AddFull (suite, "/Topology/connect_timeout/pooled",
974-
test_connect_timeout_pooled, NULL, NULL, test_framework_skip_if_slow);
975-
TestSuite_AddFull (suite, "/Topology/connect_timeout/single/try_once",
976-
test_connect_timeout_single, NULL, NULL, test_framework_skip_if_slow);
977-
TestSuite_AddFull (suite, "/Topology/connect_timeout/single/try_once_false",
978-
test_connect_timeout_try_once_false, NULL, NULL, test_framework_skip_if_slow);
979-
TestSuite_AddFull (suite, "/Topology/multiple_selection_errors",
980-
test_multiple_selection_errors,
981-
NULL, NULL, test_framework_skip_if_offline);
982-
TestSuite_Add (suite, "/Topology/connect_timeout/succeed", test_select_after_timeout);
983-
TestSuite_Add (suite, "/Topology/try_once/succeed", test_select_after_try_once);
984-
#endif
972+
if (sizeof (int *) == 4 && !windows) {
973+
TestSuite_AddFull (suite, "/Topology/cooldown/standalone",
974+
test_cooldown_standalone, NULL, NULL,
975+
test_framework_skip_if_slow);
976+
TestSuite_AddFull (suite, "/Topology/cooldown/rs",
977+
test_cooldown_rs, NULL, NULL,
978+
test_framework_skip_if_slow);
979+
TestSuite_AddFull (suite, "/Topology/connect_timeout/pooled",
980+
test_connect_timeout_pooled, NULL, NULL,
981+
test_framework_skip_if_slow);
982+
TestSuite_AddFull (suite, "/Topology/connect_timeout/single/try_once",
983+
test_connect_timeout_single, NULL, NULL,
984+
test_framework_skip_if_slow);
985+
TestSuite_AddFull (suite,
986+
"/Topology/connect_timeout/single/try_once_false",
987+
test_connect_timeout_try_once_false, NULL, NULL,
988+
test_framework_skip_if_slow);
989+
TestSuite_AddFull (suite, "/Topology/multiple_selection_errors",
990+
test_multiple_selection_errors,
991+
NULL, NULL, test_framework_skip_if_offline);
992+
TestSuite_Add (suite, "/Topology/connect_timeout/succeed",
993+
test_select_after_timeout);
994+
TestSuite_Add (suite, "/Topology/try_once/succeed",
995+
test_select_after_try_once);
996+
}
997+
985998
TestSuite_AddLive (suite, "/Topology/invalid_server_id", test_invalid_server_id);
986999
}

0 commit comments

Comments
 (0)