CDRIVER-3985 Remove Oppressive Terminology From Code (#794)

* Remove deprecated terminology for legacy hello

* Remove deprecated terminology for secondaryOk

* Remove deprecated terminology for allow/deny list

* Remove deprecated terminology for notPrimary

* Update terminology in spec tests

* Fix issues from code review

* Remove more language in docs

* Undo accidental change to hello

* Use secondaryOk when printing query flags

* Fix wrong variable name

* Remove deprecated terminology in tests

* Remove branch name from installation docs

* Clarify build examples in readme

Author: alcaeus

NEWS

@@ -2049,7 +2049,7 @@ These notable bugs have been fixed since 1.1.11:
     authentication failure
   * Off-by-one error in mongoc_gridfs_file_seek with mode SEEK_END
   * The writeConcernErrors field of bulk results is properly formatted.
-  * A cursor with a server "hint" sets slaveOkay and / or $readPreference.
+  * A cursor with a server "hint" sets secondaryOk and / or $readPreference.
   * Destroying an exhaust cursor must close its socket
   * "wtimeoutms" was ignored for write concerns besides "majority".
   * Bulk write operations might fail in mixed-version sharded clusters with
@@ -2760,7 +2760,7 @@ In this release, you will find the following changes:
   * client command functions can now take a fully qualified namespace.
   * collections can now support names that indicate a command namespace.
   * Commands will no longer fail if they do not contain an "ok" field.
-  * OP_QUERY will now set the slaveOk bit in the wire protocol if
+  * OP_QUERY will now set the secondaryOk bit in the wire protocol if
   * readPreferences are set to non-PRIMARY.
   * Various documentation and build fixes.
 

README.rst

@@ -42,7 +42,7 @@ the `MongoDB Community Forums`_ to ask for help. Please include in your post all
 information:
 
 - The version of the driver you are trying to build (branch or tag).
-    - Examples: master branch, 1.9.5 tag
+    - Examples: ``r1.17`` (branch), ``1.9.5`` (tag)
 - Host OS, version, and architecture.
     - Examples: Windows 10 64-bit x86, Ubuntu 16.04 64-bit x86, macOS 10.13
 - C Compiler and version.

src/libmongoc/CMakeLists.txt

@@ -986,7 +986,7 @@ set (test-libmongoc-sources
    ${PROJECT_SOURCE_DIR}/tests/test-mongoc-socket.c
    ${PROJECT_SOURCE_DIR}/tests/test-mongoc-speculative-auth.c
    ${PROJECT_SOURCE_DIR}/tests/test-mongoc-stream.c
-   ${PROJECT_SOURCE_DIR}/tests/test-mongoc-streamable-ismaster.c
+   ${PROJECT_SOURCE_DIR}/tests/test-mongoc-streamable-hello.c
    ${PROJECT_SOURCE_DIR}/tests/test-mongoc-thread.c
    ${PROJECT_SOURCE_DIR}/tests/test-mongoc-timeout.c
    ${PROJECT_SOURCE_DIR}/tests/test-mongoc-topology-description.c

src/libmongoc/doc/connection-pooling.rst

@@ -33,7 +33,7 @@ To activate pooled mode, create a :symbol:`mongoc_client_pool_t`:
 
   mongoc_client_pool_t *pool = mongoc_client_pool_new (uri);
 
-When your program first calls :symbol:`mongoc_client_pool_pop`, the pool launches monitoring threads in the background. Monitoring threads independently connect to all servers in the connection string. As monitoring threads receive ismaster responses from the servers, they update the shared view of the server topology. Additional monitoring threads and connections are created as new servers are discovered. Monitoring threads are terminated when servers are removed from the shared view of the server topology.
+When your program first calls :symbol:`mongoc_client_pool_pop`, the pool launches monitoring threads in the background. Monitoring threads independently connect to all servers in the connection string. As monitoring threads receive hello responses from the servers, they update the shared view of the server topology. Additional monitoring threads and connections are created as new servers are discovered. Monitoring threads are terminated when servers are removed from the shared view of the server topology.
 
 Each thread that executes MongoDB operations must check out a client from the pool:
 

src/libmongoc/doc/installing.rst

@@ -192,7 +192,7 @@ A build configuration description similar to the one above will be displayed, th
 Preparing a build from a git repository clone
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-Clone the repository and prepare the build on the current master branch or a particular release tag:
+Clone the repository and prepare the build on the current branch or a particular release tag:
 
 .. parsed-literal::
 

src/libmongoc/doc/mongoc_apm_server_heartbeat_failed_get_awaited.rst

@@ -12,7 +12,7 @@ Synopsis
   mongoc_apm_server_heartbeat_failed_get_awaited (
      const mongoc_apm_server_heartbeat_failed_t *event);
 
-Returns whether this event came from an awaitable isMaster.
+Returns whether this event came from an awaitable hello.
 
 Parameters
 ----------
@@ -22,7 +22,7 @@ Parameters
 Returns
 -------
 
-A bool indicating whether the heartbeat event came from an awaitable isMaster.
+A bool indicating whether the heartbeat event came from an awaitable hello.
 
 .. seealso::
 

src/libmongoc/doc/mongoc_apm_server_heartbeat_failed_t.rst

@@ -8,7 +8,7 @@ Heartbeat-failed event
 Synopsis
 --------
 
-An event notification sent when the driver failed to send an "isMaster" command to check the status of a server.
+An event notification sent when the driver failed to send a "hello" command to check the status of a server.
 
 .. seealso::
 

src/libmongoc/doc/mongoc_apm_server_heartbeat_started_get_awaited.rst

@@ -12,7 +12,7 @@ Synopsis
   mongoc_apm_server_heartbeat_started_get_awaited (
      const mongoc_apm_server_heartbeat_started_t *event);
 
-Returns whether this event came from an awaitable isMaster.
+Returns whether this event came from an awaitable hello.
 
 Parameters
 ----------
@@ -22,7 +22,7 @@ Parameters
 Returns
 -------
 
-A bool indicating whether the heartbeat event came from an awaitable isMaster.
+A bool indicating whether the heartbeat event came from an awaitable hello.
 
 .. seealso::
 

src/libmongoc/doc/mongoc_apm_server_heartbeat_started_t.rst

@@ -8,7 +8,7 @@ Heartbeat-started event
 Synopsis
 --------
 
-An event notification sent when the driver begins executing an "isMaster" command to check the status of a server.
+An event notification sent when the driver begins executing a "hello" command to check the status of a server.
 
 .. seealso::
 

src/libmongoc/doc/mongoc_apm_server_heartbeat_succeeded_get_awaited.rst

@@ -12,7 +12,7 @@ Synopsis
   mongoc_apm_server_heartbeat_succeeded_get_awaited (
      const mongoc_apm_server_heartbeat_succeeded_t *event);
 
-Returns whether this event came from an awaitable isMaster.
+Returns whether this event came from an awaitable hello.
 
 Parameters
 ----------
@@ -22,7 +22,7 @@ Parameters
 Returns
 -------
 
-A bool indicating whether the heartbeat event came from an awaitable isMaster.
+A bool indicating whether the heartbeat event came from an awaitable hello.
 
 .. seealso::